Change to timeout from wait_for #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_for creates a task, async_timeout does the same work and avoids the task creation
Lash-L
commented
Feb 24, 2023
| async def async_put(self, item: tuple[Any, RoborockException | None], timeout: float | int) -> None: | ||
| return await asyncio.wait_for(self.put(item), timeout=timeout) | ||
| async with async_timeout.timeout(timeout): | ||
| await self.put(item) |
Collaborator
Author
There was a problem hiding this comment.
We can put return back here if you would like, but I think it is not needed, since put does not return anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_for creates a task, async_timeout does the same work and avoids the task creation
This is one of the current optimizations they are making on HA core.
Sorry to be making so many PRS!