feat: Add v1 rooms support to the device traits API #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenporter
commented
Oct 4, 2025
Lash-L
reviewed
Oct 5, 2025
Lash-L
reviewed
Oct 5, 2025
Lash-L
requested changes
Oct 5, 2025
Collaborator
Lash-L
left a comment
Lash-L
left a comment
There was a problem hiding this comment.
just a few small comments
Contributor
Author
|
Whoops, accidentally merged this with the other outstanding PR |
Contributor
Author
|
Fixed the bad merge, but the commit history isn't as clean for review. PTAL. |
Lash-L
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trait that can return rooms and handles all the mapping from iot id to room name.
Later, we'll add an interface that helps with connecting maps and rooms together.