fix: changed incorrect s8 pro ultra string #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
approved these changes
May 5, 2023
Contributor
Author
|
@Lash-L do you need me to reword the commit message to something like |
Lash-L
changed the title
Collaborator
|
That's okay I'll squash it and it will use the title |
Collaborator
|
@humbertogontijo do you mind if I merge in PRs like this? Small changes? Didn't want to do it before checking it is okay with you |
Collaborator
go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #52 , verified the model string with my own S8 Pro Ultra.