feat: Add a trait for working with routines #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is re-exposing the web API as a trait, to make it similar to other device operations hiding the API implementation details.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a RoutinesTrait to expose routine (scene) operations through a trait interface, abstracting the underlying web API implementation. This aligns the routines functionality with other device operations that use the trait pattern.
Key changes:
- Introduces
RoutinesTraitclass withget_routines()andexecute_routine()methods - Extends
UserWebApiClientwith convenience methods for routine operations - Integrates the new trait into the V1 device properties API
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| roborock/devices/traits/v1/routines.py | New trait implementation for routine operations |
| roborock/web_api.py | Added wrapper methods for routine-related API calls |
| roborock/devices/traits/v1/init.py | Integrated RoutinesTrait into PropertiesApi |
| roborock/devices/device_manager.py | Passed web_api client to device creation |
| tests/devices/traits/v1/test_routines.py | Test coverage for the new trait |
| tests/devices/traits/v1/fixtures.py | Added web_api_client fixture for testing |
| tests/devices/test_v1_device.py | Updated device fixture with web_api mock |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Lash-L
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is re-exposing the web API as a trait, to make it similar to other device operations hiding the API implementation details.