Skip to content

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Jun 15, 2023

No description provided.

@humbertogontijo humbertogontijo merged commit 74ced28 into main Jun 15, 2023
@Lash-L
Copy link
Collaborator Author

Lash-L commented Jun 15, 2023

semantic release should be fixed now. The manual releases were missing a v before the tag. I have not been able to figure out the issue with 1.0.7 but I will maybe have more time later tonight if you don't have a chance to get to it first

@Lash-L
Copy link
Collaborator Author

Lash-L commented Jun 15, 2023

Ok figured it out, the issue is with 24.0 of python-roborock.

Something with the valley timer and dnd timer being in the get_props.

Which in my opinion, we shouldn't be doing. If you look at how I do it in core, for entities outside of status, I have non-coordinated entities, these entities make the api call directly, that way if they aren't supported or if the user disables that entity, that call wont get made. Or If I update that entity, i.e. a switch on, I can just request the new status of that entity, rather than doing an entire coordinator refresh.

The issue stems with the valley timer, not sure why but that is causing all of the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants