chore: set typing for from_code_optional to use Self #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves type safety by updating the from_code_optional method's return type annotation from RoborockModeEnum | None to Self | None, making it consistent with other methods in the RoborockModeEnum class. This change allows the removal of a type ignore comment that was previously needed.
Changes:
- Updated
from_code_optionalreturn type to useSelffor better type inference - Added a docstring to
from_code_optionalexplaining its purpose - Removed the type ignore comment and outdated TODO comment in
b01_q10_protocol.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/data/code_mappings.py | Updated from_code_optional return type from RoborockModeEnum | None to Self | None and added docstring |
| roborock/protocols/b01_q10_protocol.py | Removed type ignore comment and TODO comment that are no longer needed due to improved typing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set from_code_optional to use Self instead of the class.