Skip to content

config: increase commit header maximum length to 200 #789

Merged
allenporter merged 2 commits intoPython-roborock:mainfrom
allenporter:commitlint
Mar 20, 2026
Merged

config: increase commit header maximum length to 200 #789
allenporter merged 2 commits intoPython-roborock:mainfrom
allenporter:commitlint

Conversation

@allenporter
Copy link
Contributor

Update commitlint configuration to increase the max length to 200 to reduce # of commitlint feailures by AI generated commit titles.

Copilot AI review requested due to automatic review settings March 16, 2026 14:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Commitlint configuration to reduce lint failures from longer (AI-generated) commit titles by increasing the allowed commit header length.

Changes:

  • Adds a header-max-length rule set to 200 characters (error level).
  • Keeps the body max line length rule disabled, adjusting formatting to accommodate the new rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lash-L
Copy link
Collaborator

Lash-L commented Mar 16, 2026

Potentially worth looking at adding extra tags as well that are handled properly for our versioning? i.e. 'input' as this commit was - fails. (Make sure you fix this one on merge)

Lash-L
Lash-L previously approved these changes Mar 16, 2026
@allenporter
Copy link
Contributor Author

Ah the rule was the full stop. The tag was config, just the error printed out input. I also added the full stop exclusion if that's alright.

@Lash-L
Copy link
Collaborator

Lash-L commented Mar 16, 2026

ah, config is also not one of the types. But yeah removing full stop req is good by me.

Copy link
Collaborator

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to change commit message on merge

@allenporter allenporter merged commit 711f49e into Python-roborock:main Mar 20, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants