Skip to content

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Mar 25, 2023

In the future I'll take the time to fully convert the component to use this part of the package instead, but for now I am moving it here so that it is possible to do in the future

@humbertogontijo
Copy link
Collaborator

To be honest we should use a library or include the map with @PiotrMachowski integration. No point on keeping a copy of his code

@Lash-L Lash-L marked this pull request as draft March 25, 2023 19:43
@Lash-L
Copy link
Collaborator Author

Lash-L commented Mar 25, 2023

Agreed that would be best case. I don't believe he has a pypi package for his map parser though - and we'll need one when this part of the codebase eventually makes it to core (who knows how long that will be). I could potentially make one if he would like.

@PiotrMachowski
Copy link

I think I could make a package out of it, but it would require a significant bit of work. Before that I would prefer to use a different image rendering library - pillow seems to be a little bit slow (maybe my code is not optimized enough though).

Recently I have been working more on the Map Card instead of Map Extractor so it has some pending maintenance.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Mar 25, 2023

@PiotrMachowski awesome - let me know if I can help in anyway

@PiotrMachowski
Copy link

@Lash-L can you make a feature request in Map Extractor to keep a record of this discussion in my repo as well?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Mar 25, 2023

@Lash-L can you make a feature request in Map Extractor to keep a record of this discussion in my repo as well?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants