Contradictory terminology about native types#47
Closed
Veedrac wants to merge 1 commit intoPythonCharmers:masterfrom
Closed
Contradictory terminology about native types#47Veedrac wants to merge 1 commit intoPythonCharmers:masterfrom
Veedrac wants to merge 1 commit intoPythonCharmers:masterfrom
Conversation
edschofield
added a commit
that referenced
this pull request
May 5, 2014
edschofield
added a commit
that referenced
this pull request
May 5, 2014
Contributor
|
Thanks for the feedback, @Veedrac! A fix has just gone into v0.12. |
Contributor
Author
|
Great, thanks! The though, whereas it should be |
Contributor
|
Merged into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
future.utils.native_stris the default native string type.One would therefore conclude that
future.utils.bytes_to_native_strwas the correct way to turnnewbytesinto anative_str, at least on Python 2. This does not work, as it is in fact a no-op on Python 2.Personally this could be solved with a hint in the docstring (and a pointer to use
native), but it could also be seen as a naming or coding bug.Thanks for the lovely work. :)