Correctly mark tests that are successful on 3.x.#70
Merged
edschofield merged 1 commit intoPythonCharmers:v0.12.xfrom Jun 19, 2014
Merged
Correctly mark tests that are successful on 3.x.#70edschofield merged 1 commit intoPythonCharmers:v0.12.xfrom
edschofield merged 1 commit intoPythonCharmers:v0.12.xfrom
Conversation
edschofield
added a commit
that referenced
this pull request
Jun 19, 2014
Correctly mark tests that are successful on 3.x.
Contributor
|
All the tests are now passing again on Travis-CI. Well done and thanks for your help! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These need to be marked correctly because 3.4's unittest treats unexpected successes as a failure of the entire build.
Note, in most cases, I did not check whether these tests really should be successes; I just made explicit what's already happening.