[MRG] Fix Fused Gromov Wasserstein implementation #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
alphatrade-off parameter of the Fused Gromov Wasserstein implementation was not used correctly: what was computed wasinstead of the convex combination
Even though the two are mathematically equivalent up to a rescaling of alpha, it was not consistent with the documentation. I changed the implementation so
optim.cgis called withcg(..., (1-alpha)*M, alpha, ...)instead ofcg(..., M, alpha, ...)which should be enough to fix this issue.