-
Notifications
You must be signed in to change notification settings - Fork 540
[MRG] inits for sr(F)GW + srGW barycenter + exemples #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
==========================================
+ Coverage 96.78% 96.85% +0.06%
==========================================
Files 88 88
Lines 17506 17910 +404
==========================================
+ Hits 16944 17346 +402
- Misses 562 564 +2 |
rflamary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cedricvincentcuaz , a few comments
|
Thank you for your review @rflamary, I've finished taking your comments into account. |
Types of changes
semirelaxed_init_planinot.gromov._utils.py.G0to also be a string among admissible init methods.semirelaxed_gromov_barycentersfollowing API ofgromov_barycenters, while addingG0 : strto leverage init methods insemirelaxed_init_planto both init transport plans and the barycenter.semirelaxed_cginot.optim: relaxing the identification of the minimum in the gradient with a small margin to take into account precision errors. This was causing issues of consistency across backends.tol_relandtol_absparameters used in the solverot.solve_gromov, whereas only parametertolis used in entropic sr(F)GW solvers.Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist