Skip to content

[MRG] Reverting openmp compilation flags for macOS #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rflamary merged 5 commits into from
Feb 19, 2026
+1 −3
Merged

[MRG] Reverting openmp compilation flags for macOS #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f3dc42
Reverting openmp compilation flags
dcoeurjo Feb 18, 2026
a50746a
Reverting openmp compilation flags (ruff-format)
dcoeurjo Feb 18, 2026
b1b2e80
Wring PR number
dcoeurjo Feb 18, 2026
c4df840
Typo in new test
dcoeurjo Feb 18, 2026
91c759c
Removing tes_ot_openmp (already tested in test_ot)
dcoeurjo Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ This new release adds support for sparse cost matrices and a new lazy EMD solver
- Clean documentation (PR #787)
- Fix code coverage (PR #791)
- Fix test of the version of jax in `ot.backend` (PR #794)
- Reverting the openmp fix on macOS (PR #789) for macOS (PR #797)


## 0.9.6.post1
Expand Down
3 changes: 0 additions & 3 deletions ot/helpers/openmp_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,13 @@ def get_openmp_flag(compiler):
omp_flag = ["-fopenmp"]
if sys.platform.startswith("darwin"):
omp_flag = ["-Xpreprocessor", "-fopenmp"]
omp_flag += ["-I/usr/local/opt/libomp/include"]
# Assuming `brew install libomp` on recent macOS
if os.path.isfile("/opt/homebrew/opt/libomp/lib/libomp.dylib"):
omp_flag += ["-I/opt/homebrew/opt/libomp/include"]
omp_flag += ["/opt/homebrew/opt/libomp/lib/libomp.dylib"]
else:
# Assuming `brew install libomp` on old macOS
if os.path.isfile("/usr/local/opt/libomp/lib/libomp.dylib"):
omp_flag += ["-I/usr/local/opt/libomp/include"]
omp_flag += ["/usr/local/opt/libomp/lib/libomp.dylib"]

return omp_flag

Expand Down
Loading