Added code for plotting PIGs#23
Merged
MatthiasRoelsPython merged 2 commits intomasterfrom Dec 22, 2020
Merged
Conversation
PEP-8 naming convention for functions and class methods states that names should be in snake case (with underscore chars). So plotIncidence should be plot_incidence. Note that the former is used a lot amongst web developers (Flask apps, Django apps, ...)
MatthiasRoelsPython
approved these changes
Dec 22, 2020
Contributor
MatthiasRoelsPython
left a comment
MatthiasRoelsPython
left a comment
There was a problem hiding this comment.
Looks good! I only changed the name plotIncidence to plot_incidence to comply with PEP-8 which is used throughout cobra.
JanBenisek
added a commit
that referenced
this pull request
Jan 4, 2021
Added short description and code of the PIG plotting function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added feature to plot PIGs & one small test to test it.
It is a simple function, with possibility to specify an order of x-axis.
Now I am not sure whether it is in the correct file -
pigs_tables.pyand notplotting_utils.py.Let me know what you think.
(after, documentation should be updated)