Skip to content

fix: JSON exit-code asymmetry in check_orphans and check_assets#60

Merged
PythonWoods-Dev merged 1 commit intomainfrom
fix/json-exit-code-asymmetry
Apr 16, 2026
Merged

fix: JSON exit-code asymmetry in check_orphans and check_assets#60
PythonWoods-Dev merged 1 commit intomainfrom
fix/json-exit-code-asymmetry

Conversation

@PythonWoods-Dev
Copy link
Copy Markdown
Contributor

@PythonWoods-Dev PythonWoods-Dev commented Apr 16, 2026

Summary

  • check_orphans and check_assets in JSON mode now distinguish error vs warning severity before deciding exit codes
  • Previously, any finding (including warnings) triggered Exit 1 — inconsistent with check_references and check_snippets
  • All 963 tests pass

Related

Follows up on PR #55 (--format json on individual check commands)

Both commands now check finding severity (error vs warning) before
deciding exit codes, consistent with check_references and check_snippets.
Warnings no longer trigger Exit 1 in JSON mode.
@PythonWoods-Dev PythonWoods-Dev merged commit 1f5613c into main Apr 16, 2026
6 checks passed
@PythonWoods-Dev PythonWoods-Dev deleted the fix/json-exit-code-asymmetry branch April 17, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant