This repository was archived by the owner on Apr 5, 2025. It is now read-only.
When replacing a Track, the Player will now display the proper track #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MujyKun
changed the title
Member
|
Technically this branch is not receiving any new updates. But since this is a relatively simple bug, I will merge. Thanks for the PR! 💛 If you feel like contributing more feel free to check out the 1.0 branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a song is playing and another song is replacing it without stopping the initial song, the hook event will get called after it is already replaced. This will leave the
Playerto assume it is not playing and will not contain any information about the current playingTrack.I've added an attribute and checks in place for when a new Track has been played so the
TrackEndevent does not override the current Track to None.