CHANGE expose vm's ui state as stateflow#56
Merged
Conversation
…t twice (this also solves a possible flickering default state bug, when re-opening this screen and a state change from the viewmodel is preceded by the default state for a split second)
sebaslogen
previously approved these changes
Feb 23, 2024
Collaborator
sebaslogen
left a comment
sebaslogen
left a comment
There was a problem hiding this comment.
Nice improvement, it's looking good and I have an improvement suggestion
core/navigation/src/main/kotlin/nl/q42/template/navigation/viewmodel/InitNavigator.kt
Show resolved
Hide resolved
feature/home/src/main/kotlin/nl/q42/template/presentation/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
feature/home/src/main/kotlin/nl/q42/template/presentation/home/second/HomeSecondViewModel.kt
Outdated
Show resolved
Hide resolved
...ng/src/main/kotlin/nl/q42/template/presentation/onboarding/start/OnboardingStartViewModel.kt
Outdated
Show resolved
Hide resolved
Frank1234
dismissed stale reviews from ninovanhooff and sebaslogen
via
bf14ff4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expose vm's ui state as stateflow: