Adds open and closed intervals#35
Merged
Merged
Conversation
Contributor
Author
|
r2g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title. I needed open intervals to implement partitioned affine intervals.
AFAIK Boost only supports closed intervals, so I rolled the logic myself. This created a rather nasty series of if/else statements on the backend of the Interval class. I strongly suspect the open/closed-ness of an operation follows some sort of boolean algebra and can be optimized by working that algebra out. That's a task for another day. For now, the focus is on correctness.