Skip to content

Remove AGP wavefunction#5818

Merged
prckent merged 1 commit intoQMCPACK:developfrom
prckent:sadly_remove_agp
Feb 17, 2026
Merged

Remove AGP wavefunction#5818
prckent merged 1 commit intoQMCPACK:developfrom
prckent:sadly_remove_agp

Conversation

@prckent
Copy link
Copy Markdown
Contributor

@prckent prckent commented Feb 17, 2026

Proposed changes

Remove the AGP wavefunction implementation.

Unfortunately we have no current knowledge of the status of this old implementation, no inputs, no tests, no archived results, and no users are known. Although an up to date and tested AGP implementation would be very welcome, given the age and status of this code, starting from scratch with the batched drivers in mind might be preferred. The old code will remain accessible in the git history and prior releases.

What type(s) of changes does this code introduce?

  • Bugfix
  • New feature
  • Build related changes

Does this introduce a breaking change?

  • Yes

What systems has this change been tested on?

Ubu24, no-mpi build checked.

Checklist

Update the following with an [x] where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@ye-luo
Copy link
Copy Markdown
Contributor

ye-luo commented Feb 17, 2026

Test this please

@prckent prckent merged commit 7e95960 into QMCPACK:develop Feb 17, 2026
45 checks passed
@prckent prckent deleted the sadly_remove_agp branch February 17, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants