Remove AGP wavefunction#5818
Merged
prckent merged 1 commit intoQMCPACK:developfrom Feb 17, 2026
Merged
Conversation
ye-luo
approved these changes
Feb 17, 2026
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the AGP wavefunction implementation.
Unfortunately we have no current knowledge of the status of this old implementation, no inputs, no tests, no archived results, and no users are known. Although an up to date and tested AGP implementation would be very welcome, given the age and status of this code, starting from scratch with the batched drivers in mind might be preferred. The old code will remain accessible in the git history and prior releases.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Ubu24, no-mpi build checked.
Checklist
Update the following with an [x] where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.