[pull] main from chromium:main#360
Merged
pull[bot] merged 50 commits intoQSLee-Net:mainfrom May 15, 2023
Merged
Conversation
Bug: b/278626041 Change-Id: Ic639518bd48055e82d4a21acd6f3fb4d3742171c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4528563 Reviewed-by: Roman Arora <romanarora@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143791}
…merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iedb374ca981d856e14bdb7fe85ad62f74d6b295e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531136 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143792}
Roll Chrome Win64 PGO profile from chrome-win64-main-1684064346-c8937d76f8b72c1aa5c8b203bd3f30ce3a014dfd.profdata to chrome-win64-main-1684076312-15e81421156ef1b2a45a404c546ada7258e72a7f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0cdc44f534756907b44d10063c8d2add4fe94750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531133 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143793}
…ERS. This suggested change is automatically generated based on group memberships and affiliations. If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change. See the owner's recent activity for context: https://chromium-review.googlesource.com/q/rwkeane@google.com To report an issue, file a bug in the Infra>Security component. Change-Id: Id449abe21e7d696f43567b48871153eeaebd640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4528447 Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143794}
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md for information about this conversion. Bug: 1280317 Change-Id: I6644855b73b47d29f05145f0dbf91fc42e540c96 Include-Ci-Only-Tests: true Validate-Test-Flakiness: skip Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4530076 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143795}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202305140800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/JWnJece1g2Y9kaCFW3udsuS3QNa18vcoRZqpc0Y_ueUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC cros-essential-apps-dev@chromium.org,jomag@google.com,media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Id139366a77744efa58ff099e9cb33b99c1f48c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531128 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143796}
Clicking on an extension's site access toggle grants/withholds site access in the current site. If the extension can only have access on click (that is, extension only requested active tab) it grants tab permissions just one time. To test for this functionality, we combined the tests for site access toggle and site permissions button as both have the same setup and should change for the same scenarios. Screencast: https://drive.google.com/file/d/1POGicf22Viv0xU-NynZZ4uJ7HygFKSJN/view?usp=sharing Bug: 1239772 Change-Id: I78da2d08dcb3664b5ce859efe34768980e255aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481785 Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143797}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/3a28014a794e..0bcaeedbf47f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: Ib07552d290e05d2a832ddd5a28f31418aaef8e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531226 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143798}
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1684064346-1748b6a61ebc82d5334f489da0746a21af47e551.profdata to chrome-chromeos-amd64-generic-main-1684078416-606cdfa63592671d532fb7729035177ebd1089f0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-lacros-amd64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibde52c75fbbc07eab1ab3a318d87d1f151a8fd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529210 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143799}
This CL updates the ash version ['115.0.5771.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I591fda3c8fd291d1c1f02a0cc32cac35401791d6 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529381 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143800}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1684078416-b76a9741fd0a3ded3d538581de8ab5f010c7e037.profdata to chrome-mac-arm-main-1684087171-cc466b320836c339da017226289da0bfc28a79f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic0386dd2c14edc1be382417c28b56d92f2058709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531228 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143801}
Roll Chrome Linux PGO profile from chrome-linux-main-1684064346-b440f1b9f7f817ee8eb49860584865c5e87bfaf5.profdata to chrome-linux-main-1684087171-f167275cf0752c3218ce0cf4a353d636a8ad577a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id41604b7c3975161da799e81cdb9383caccd33b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531264 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143802}
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/578c7bfbb181..64e39cf4ffa9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/devtools-internal-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com,liviurau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I60dd68c06c02adc58e7d5b3502f93e4f4030f80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529212 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143803}
Roll Chrome Mac PGO profile from chrome-mac-main-1684064346-6c80feb98737df3f5b3791363d3b7c075af7e6be.profdata to chrome-mac-main-1684087171-74ff9e295f837a28589253e29c12163d263f3286.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I655a8d1f2ffd6e6172a78e5dca6989d5fe74e945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529213 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143804}
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/1afcd44449fe..263f0bdb5d37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC chrome-brapp-engprod@google.com,erahmaoui@google.com,sdefresne@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I7ebb2868cc693308a0fe1a079980c2aac8a2b8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531268 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143805}
Roll Chrome Win64 PGO profile from chrome-win64-main-1684076312-15e81421156ef1b2a45a404c546ada7258e72a7f.profdata to chrome-win64-main-1684087171-bd0297f2486982d90c5001ff87206037a294686c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iedd6d168d59753a2a507f7189ae50d1881fd5d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531263 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143806}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1684087171-cc466b320836c339da017226289da0bfc28a79f4.profdata to chrome-mac-arm-main-1684093941-cf8b285e1449591456b8a540c9634d5372df7aa7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I01bcdd001579935a21b82d0bc04274beaefe1e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531233 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143807}
Change-Id: I21b46889a277016732f5589afc8d308813a458a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529317 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143808}
Roll Chrome Win32 PGO profile from chrome-win32-main-1684054749-afc426f5ce0a3f351c6eb4f6f27b1a6dd9701440.profdata to chrome-win32-main-1684087171-645dc3eb560a5916b14fc777ea8997ee66b36e03.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie5d136723da8ec72839f74473e43f1acfb3fbd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531231 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143809}
…5762.0-r1 to 115-5735.12-1683543901-benchmark-115.0.5767.2-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I88406585409c75885a3d9468e5596a2faa2adaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531234 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143810}
Adds the metrics for interacting with non-empty note text in revamped password management bubble: * Copying note (full / part of it) * Selecting note (full / part of it) The logic is added on events: * OnKeyPressed (ctrl-c / ctrl-a) * OnMouseReleased (selecting text with a mouse) * ExecuteCommand (select all / copy) Bug: 1416246 Change-Id: I2097655acd53bc2f806f6fbefd6da09c02e6be7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4512957 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Rafał Godlewski <rgod@google.com> Cr-Commit-Position: refs/heads/main@{#1143811}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/0bcaeedbf47f..720ece27cfd8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: Ic70dc24487f85746b540bc84b6ea8ee2124942be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531237 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143812}
…15.0.5769.0-r1 to 115-5715.0-1683546756-benchmark-115.0.5770.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib9f5d15e84b5f3f780e3a15c8f430ecacb20912a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531238 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143813}
…6-benchmark-115.0.5769.0-r1 to 115-5715.0-1683546756-benchmark-115.0.5770.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I140fcc85fb21b51dbce64e5801ee970f5b63a1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531239 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143814}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium Please CC chrome-fuchsia-gardener@grotations.appspotmail.com,chrome-fuchsia-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I1b50eb6b7e8763be78dd0305cce4fcafe4d652d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531269 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143815}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/720ece27cfd8..a76391854b51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: I317796cb1d11da15fe68d4fbc3f59a1548b31508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531275 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143816}
…-115.0.5769.0-r1 to 115-5735.12-1683543901-benchmark-115.0.5770.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If52b3cd42d307fc9de30b9d0a2524ad8e00c255d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531240 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143817}
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1684078416-606cdfa63592671d532fb7729035177ebd1089f0.profdata to chrome-chromeos-amd64-generic-main-1684093941-023fadb9019a49fa58db8e0d582b145fcd51d83e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-lacros-amd64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifac3a13d97b173c657779862be80106e47fd54b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531241 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143818}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1684093941-cf8b285e1449591456b8a540c9634d5372df7aa7.profdata to chrome-mac-arm-main-1684101322-5ff50f27f02bc0d19983077f57805c31dc7e04dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I618ee673ea5902aaba0014c3277943c37e0aa1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531278 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143819}
…ark-115.0.5769.0-r1 to 115-5735.12-1683542912-benchmark-115.0.5770.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I22e73b4c7f1b9011d3dbd8ec98eeb9da4511d75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531279 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143820}
* BUILD.gn: Add //third_party/pyjson5/ dependency for blink_python_tests. * PRESUBMIT.py: * scripts.gni: * run_blinkpy_tests.py: Add third_party/pyjson5/src to PYTHONPATH * css_properties_ranking.json5: * event_target_names.json5: * event_target_chromeos_names.json5: * event_target_modules_names.json5: Fix syntax errors. Bug: 1444901 Change-Id: I359373e53b795d60251fb842e7a627c03f11d66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4525215 Reviewed-by: Dirk Pranke <dpranke@google.com> Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143821}
Roll Chrome Win32 PGO profile from chrome-win32-main-1684087171-645dc3eb560a5916b14fc777ea8997ee66b36e03.profdata to chrome-win32-main-1684097791-8df2f211b43ed1501d462056fce2d3aea90c1f41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib2090d2836d62bea9885c03c63bb16e69714d329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531274 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143822}
Roll Chrome Win64 PGO profile from chrome-win64-main-1684087171-bd0297f2486982d90c5001ff87206037a294686c.profdata to chrome-win64-main-1684097791-e01232f849d4cdac23c20fc503817739c256dc4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I095b4487ee91dcd9fcd714b3dbd015be6f17b642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531273 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143823}
Associate test result with feature_id tag. Bug=b:266011653 TEST=N/A Change-Id: I3a82fc0a97c022b1ee10e29fefb066167fd45d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520046 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Charles Zhao <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143824}
Currently we send suggestions from the ime service to be displayed by the system in the mojom call InputMethodHost::DisplaySuggestions(). This method sends the suggestions without any other textual information. This CL updates this method and adds a new optional param (for backwards compat) preceding_text. This param contains the preceding text that was used by the service to generate the suggestions given. This extra context will allow consumers of the method to make a better decision as to whether they should display the suggestions or not. BUG=b:278800045 Change-Id: I87b4763a4ab0753f9dcc52a0ab24315ac36e078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4511752 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143825}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/a76391854b51..a7a77c92faa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: If29260297e1b12604763db4b563806c56d9cc5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4530827 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143826}
Add links to the ODFS reauthentication required (empty) state. Bring the "empty-folder.label" element to the top so that clicks reach the links in the label and are not absorbed by the empty "file-list". Clicks outside of the label are absorbed by the "file-list", so for example, the context menu can be shown in the empty state. Links: - Sign in -> calls onODFSSignIn_ - Settings -> calls onSettings_ Screenshot: https://screenshot.googleplex.com/3d4JrwewAHqFqBJ.png Bug: b:279109210 Change-Id: Ieae8b1769df7087931ac1cc574c8497c0363e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4521141 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Cassy Chun-Crogan <cassycc@google.com> Cr-Commit-Position: refs/heads/main@{#1143827}
* Get an instance of `ProgressCenter` by `pc = fileManager.progressCenter`. * Use the instance method of ProgressCenter: * `pc.addProgressingTestItem_(props)` * `pc.addCompletedTestItem_(props)` * `pc.addErrorTestItem_(props)` * `pc.addScanningTestItem_(props)` * `pc.addPausedTestItem_(props)` Demo: http://go/scrcast/NTUzMDgzNjI0Njk4Njc1Mnw3OWUzYWEyMy02Yg Bug: b:242938480 Change-Id: Ic997acc3a5d32311c69b1104194ed43a7910aeb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520186 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Wenbo Jie <wenbojie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143828}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/a7a77c92faa6..3e150281d803 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: If55168e1ccfee19ecd1aa3721c5e97842de3da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529087 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143829}
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1684093941-023fadb9019a49fa58db8e0d582b145fcd51d83e.profdata to chrome-chromeos-amd64-generic-main-1684107933-6630957349852c29f0f2266cc0522fe331f63980.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-lacros-amd64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I6782e84f98ac8bb8706cbc9c7aadc0f6a2ee74cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531368 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143830}
AddressList was replaced with HostResolverEndpointResult. Bug: N/A Change-Id: Ibf120ee05c74ad84dcc74da4c7110686f439ecdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4525776 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143831}
We use the file handler default prefs to determine whether setup should be run or not now. This means we can remove the 'setup complete' pref. Update files-internals to show the file handlers set in prefs for office file types, and add the ability to clear them for testing purposes. Low-Coverage-Reason: Low coverage refers to debug code only Bug: b/275912658 Change-Id: I68764cc2fe26d3b547f515544e6604e27aaa0e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520460 Reviewed-by: Dominic Battre <battre@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Reviewed-by: Victor Vianna <victorvianna@google.com> Reviewed-by: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143832}
We can detect when Drive is not mounted, which can be because Drive is explicitly disabled in Settings. Prioritise this error over the offline error for the fallback dialog, because offline checks whether Drive is connected, which can lead to the offline error showing when the device is actually online. Clean up some other categories of fallback errors that are no longer used. Bug: b/281773568 Change-Id: I6edf42403aee7bdf8f811dc39fc77c26556b197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520494 Reviewed-by: Cassy Chun-Crogan <cassycc@google.com> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143833}
Make MediaNotificationProviderImpl instantiate SupplementalDevicePickerProducer, which gets requests from Lacros via the crosapi to show media notifications containing device pickers when there's no active media associated with the request. Bug: 1432004 Change-Id: Ib97713f6874a017bf08804d3df959dea0411eb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4439011 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143834}
This disables ExtensionsMenuMainPageViewUnitTest.ActiveTabRequested_ToggleSiteAccess on Windows ASan. Bug: 1445397 Change-Id: Idaf6131f055bbb0a975174d8c7a69720b427ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531164 Auto-Submit: Kunihiko Sakamoto <ksakamoto@chromium.org> Owners-Override: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143835}
It gets instantiated by CastMediaNotificationProducerKeyedService, so MediaNotificationService should not instantiate it. Bug: 1444946 Change-Id: I56ad0ae6a29b3499cc994f9f717700119cf23cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4523453 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143836}
…y default."" This reverts commit 8dcd193. Reason for revert: b/282568012 Original change's description: > Reland "Enabling "gettring rid of ConsumedByIme heuristics" by default." > > This reverts commit 7969f07. > > Reason for revert: the fix was landed. > > Original change's description: > > Revert "Enabling "gettring rid of ConsumedByIme heuristics" by default." > > > > This reverts commit 48e5f98. > > > > Reason for revert: breaks the CQ: b/276464260 > > > > Original change's description: > > > Enabling "gettring rid of ConsumedByIme heuristics" by default. > > > > > > BUG=1401822 > > > TEST=Ran tryjob. Manually test the UJ in 1401822 with enabling the > > > new feature, and fix was verified. > > > Tast run: arc.PhysicalKeyboard.vm arc.PhysicalKeyboardAllkeys.vm > > > arc.ChromeVirtualKeyboard.vm arc.AndroidIMEInBrowser.vm > > > arc.StandardizedKeyboardCopyPaste.vm{,_tablet_mode} > > > arc.StandardizedKeyboardKeys.vm{,_tablet_mode} > > > arc.StandardizedKeyboardTyping.vm{,_tablet_mode} > > > arc.IMEBlocking.vm > > > > > > Change-Id: I4e753b1151af14af660a3f26315b579695f58457 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369189 > > > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > > > Reviewed-by: Timothy Loh <timloh@chromium.org> > > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1123549} > > > > Bug: 1401822, b:276464260 > > Change-Id: I29eab7c5005b17075f8a76fc8cc3b8e39337d01d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4390788 > > Owners-Override: Ana Salazar Maldonado <anasalazar@google.com> > > Commit-Queue: Ana Salazar Maldonado <anasalazar@google.com> > > Auto-Submit: Ana Salazar Maldonado <anasalazar@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1125002} > > Bug: 1401822, b:276464260 > Test: in addition to the original CL, > inputs.PhysicalKeyboardLongpressDiacritics.lacros having caused > the previous revert. > > Change-Id: I1c699c1e9609f0c21592ea99ac163b46f9e108a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496007 > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1138131} Bug: 1401822, b:276464260 Change-Id: Ief61eab721be714daf5ba56c34548f14a4afa343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531444 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Alvin Jia <alvinjia@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1143837}
This CL adds empty network service out of process for measuring memory impact on Android. The empty network service lives on new utility process and virtually does nothing (implementation is ~20 lines of code in c/u/services.cc.) The empty service is enabled only if the canonical network service is in process to see additional process overhead on Android. Bug: 1395707 Change-Id: Ieb0902a87134d1ae0af56f6b9d7940944863e450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374282 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143838}
* Make AtomicString constructors explicit only for renderer/platform/. We'll expand it to all components. * Add some strings to font_family_names.json5 and http_names.json5, and use them, or * Explicitly add AtomicString(...). Bug: 1444094 Change-Id: I5e3b14769a69d7fe7c3df5263a80d6cbda88a564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520246 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143839}
512-bit RSA was factored back in 1999, before Chrome even existed. We're looking to set minimum RSA key sizes in BoringSSL, preferably a limit that doesn't allow something that was already insecure in 1999! Bug: boringssl:607 Change-Id: I84f11f38e588b0cc627380bacb06b3e8a53057fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529975 Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1143840}
pull bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
https://chromium.googlesource.com/external/github.com/WebKit/Speedometer.git/+log/2ee210ca2076..7b1b81ee1319 $ git log 2ee210ca2..7b1b81ee1 --date=short --no-merges --format='%ad %ae %s' 2024-01-31 tkober fix clear-completed (#364) 2024-01-30 issackjohn Npm audit fix (#360) 2024-01-25 camillobruni Remove test-again button (#358) 2024-01-25 camillobruni Adjust dot size to iterationCount (#356) 2024-01-25 camillobruni Update document title (#354) 2024-01-25 camillobruni Fix navigation recursion (#357) 2024-01-25 camillobruni Fix navigation for Firefox (#353) 2024-01-22 felash Run format on a previously unformatted file 2024-01-22 felash Configure the next eslint plugin so that there's no false positive error when running eslint 2024-01-22 felash Add root: true to the top level eslint configuration file 2024-01-22 felash Makes tsx files checked by the formatters. 2024-01-22 felash Remove tentative from the prettier and eslint ignore lists 2024-01-17 camillobruni Allow empty hash for cleaner default URLs on the home screen (#349) 2024-01-11 issackjohn Fix Complex vs. non-complex DOM subtests order (#343) 2024-01-11 rniwa Always instantiate Float32Array in the cost array of findOptimalSegmentationInternal. (#342) 2023-12-21 issackjohn Regenerate package-lock.json (#339) 2023-12-21 issackjohn Enable complex DOM benchmarks execution in official speedometer run (#271) 2023-12-21 issackjohn Fixes #335: Prevent complex DOM workloads from hitting a specific WebKit pathology (#338) 2023-11-29 felash Keep the parameter 'tags' as an array in the body of the function (#337) 2023-11-20 camillobruni Avoid setTimeout in waitOnElement (#321) Created with: roll-dep src/third_party/speedometer/v3.0 Change-Id: Iebefd528570e6c1ff9dbbee55da1997863ff8a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259541 Commit-Queue: Issack John <issackjohn@microsoft.com> Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Luis Fernando Pardo Sixtos <lpardosixtos@microsoft.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255652}
pull bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo/+log/38b1af9c619b..e3f82e8f64f8 2025-12-30 fbarchard@google.com Blizzard duplicate return removed (#360) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/cpuinfo-chromium Please CC chrome-intelligence-core@google.com,rmcelrath@google.com on the revert to ensure that a human is aware of the problem. To file a bug in cpuinfo: https://github.com/pytorch/cpuinfo/issues To file a bug in Chromium: https://b.corp.google.com/issues/new?component=1405550 To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux;luci.chrome.try:optimization_guide-mac-arm64;luci.chrome.try:optimization_guide-mac-x64;luci.chrome.try:optimization_guide-win32;luci.chrome.try:optimization_guide-win64 Bug: None Tbr: rmcelrath@google.com Include-Ci-Only-Tests: chromium.android:android-pie-arm64-rel|android_browsertests Change-Id: I127d012858ac269acb8e250031206729f86cf864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7362125 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1563479}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )