[pull] main from chromium:main#397
Merged
pull[bot] merged 991 commits intoQSLee-Net:mainfrom Jul 25, 2023
Merged
Conversation
Provides most UI changes for v2 of Drive Module. Future CLs will (most likely): 1. Update the value of variables used for colors. This does not involve adding or removing color attributes from drive/module.html. This CL makes it so the Drive module uses the colors used by all v2 modules, However, the values of the colors deviate from the Launchpad 2.0 specs. 2. Increase the number of files shown in the Drive module from 3 to 6. 3. Edit the max width of the entire modules layout. (screenshot/BUsrgLaYXao7hKa). *Specs in bug description* narrow layout: screenshot/6YAHM3MaQhJKmnm wide layout: screenshot/9voRmsugfpzkSrc To show the margins on the Drive module, I edited its background color in dev tools: screenshot/9eZu3d48j9CrNPn. Change-Id: I8c12a0b5eb6b2524212460fa3ec95d7df305751c Bug: 1446336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712245 Commit-Queue: Paul Adedeji <pauladedeji@google.com> Reviewed-by: Roman Arora <romanarora@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174877}
Bug: b/278758667,1428679,1293026 Change-Id: I0f985c752f67e528fdeb61afa64b0c5e9b9b7f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712668 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Luc Nguyen <lucnguyen@google.com> Cr-Commit-Position: refs/heads/main@{#1174878}
Updating first patch of final strings in the unified settings view. Marking them translatable. Bug: 1449220 Change-Id: Ieeef720f89c66e2e9739aa9d6ca144174a539a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4711732 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Jood Hajeer <jood@google.com> Cr-Commit-Position: refs/heads/main@{#1174879}
A notification preview can show at most ~170 characters. Since app names may be long we could run out of space towards the end of the notification message and it would be cut off. The font used isn't monospaced and we want to be cautious and limit the notification to 150 characters by showing the generic notification message without any app names if we exceed the limit. Bug: b:289968470 Change-Id: I7953ae1ae5e23c7f1f969f6d0b14432cd210b566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4684148 Commit-Queue: Christoph Schlosser <cschlosser@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174880}
Bug: b/280365853 Change-Id: Ie148165f77542401c819e1b4e65b9f3e26d507d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712232 Commit-Queue: Nasser Al-shawwa <alshawwa@chromium.org> Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174881}
There is a minor crash occurring here on some devices running WebView. In this case we should catch the Resources.NotFoundException and return a null icon for the selection menu items. Bug: 1454900 Change-Id: Iac7093d789c0ef47409e4c2f2b168fef86b493fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4711812 Commit-Queue: Wayne Jackson Jr. <wbjacksonjr@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174882}
This change fixes a longstanding bug in the PNA implementation for iframes. PNA checks apply to the fetch client's policies, not the parent frame's policies. Also introduce a couple new feature flags to control the rollout of PNA for iframes: warning-only mode and full enforcement. These replace the previous feature flag, which only applied to non-secure contexts. The feature flag checking logic is moved to live inside `DerivePrivateNetworkRequestPolicy()`, as is the case for worker flags. A couple virtual test suites are introduced to exercise the code paths behind the two new flags. These show that there remain bugs when the feature is entirely enabled: preflight requests do not succeed. This seems to be due to a strange interaction of CORS logic with PNA, where navigation requests are made in no-cors mode with credentials. Further work is needed to fix this, either by fixing the tests or by fixing CORS logic. Bug: chromium:1170335 Change-Id: Iea67b39c46ff48edac3f51e9ccc63d4bac47b7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3945088 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174883}
We are removing deduplication logic of bookmarks/mv tiles spotlight items, as we will rely on displaying domain labels for the items. Bug: None Change-Id: Ice9c550702194920bc847ca5e30be0d5b6db605b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4678904 Commit-Queue: Ameur Hosni <ameurhosni@google.com> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174884}
This allows checking if the Vulkan driver supports importing and exporting of external semaphore objects. Bug: 1411745 Change-Id: I1b703f9915b5ec4e02635ba3d96060fe82eccde3 Low-Coverage-Reason: Vulkan is not used by default on most platforms Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4689116 Commit-Queue: Quang Minh Phan <phanquangminh217@gmail.com> Reviewed-by: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174885}
Bug: 1446474 Change-Id: Ic3b0c181724e5753a6072caa9955c5b3be01661a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4715919 Commit-Queue: Shanthanu Bhardwaj <xanth@google.com> Owners-Override: Dominique Fauteux-Chapleau <domfc@google.com> Reviewed-by: Shanthanu Bhardwaj <xanth@google.com> Cr-Commit-Position: refs/heads/main@{#1174886}
Old: https://screenshot.googleplex.com/5Wdpsma8urKtyXv New: https://screenshot.googleplex.com/asdhBUgZMHi6sgW Bug: b:293104421 Change-Id: I1bf04f011b6d09c78692b0e0dedfb138503f348a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4714911 Commit-Queue: Simon Ziegltrum <ziegltrum@google.com> Reviewed-by: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/main@{#1174887}
https://chromium-review.googlesource.com/c/chromium/src/+/4670681 fixed the case where the finalVisibleCharIndex corresponds to non LTR text. However, we found that getOffsetForAdvance would still return an incorrect index, as long as if there is non LTR text before that index, even if the text overlapping finalVisibleCharIndex is LTR. This cl resets the visible hint if any RTL text is encountered before finalVisibleCharIndex. Bug: 1465967 Change-Id: Ic9a184fcd4f41e114fb82b84e6bfcabac3103c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712691 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Peilin Wang <peilinwang@google.com> Cr-Commit-Position: refs/heads/main@{#1174888}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd802a40..3e9e907c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I19e0842a369f773c3ecb4bbd1c5ca9efbfd4471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4715739 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1174889}
With this CL, the overflow menu orderer now correctly handles and persists the whether destination usage history is enabled or disabled (including due to flag change). It also correctly resets the state of the destination usage history when it gets re-enabled. There are also some small clean ups to destination usage history of lines were incorrectly left in from previous CLs. Bug: 1445203 Change-Id: I936b6dfa62a4e4f9c762c72e5fa233ec096f660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4708394 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Nicolas MacBeth <nicolasmacbeth@google.com> Reviewed-by: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/main@{#1174890}
This CL makes the following changes: * Removes `RunScript` in favor of just calling EvalJs directly in tests. This makes the test behavior slightly more straightforward. * Removes `PopConsole`, since it's a trivial wrapper around PopConsoleString, and the callsites are clearer without the wrapper. * Moves EXPECT_* calls into the bodies of the helpers that are never expected to fail. This makes the tests a bit less "noisy", and makes it impossible for a test to forget to check the assertion. * Replaces EXPECT_TRUE(x == y) with EXPECT_EQ(x, y). This lets the test give better error messages in the event of a failure. Change-Id: I0d0aae2af950359f277c58080777a4f3b0dc99f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4710025 Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174891}
This CL adds handling the end_of_stream() buffer, by initiating the V4L2 Drain procedure [1]. Note how the |decode_cb| associated with that Decode() call has to be kept around until after the Drain is finished. The code includes sending a V4L2_DEC_CMD_STOP to the queue, which is also done in V4L2StatefulVideoDecoderBackend, so all of that is put into a new function in v4l2_utils.cc. With this CL the v_d_a_tests FlushAtEndOfStream passes (concretely /usr/local/libexec/chrome-binary-tests/video_decode_accelerator_tests /usr/local/share/tast/data_pushed/go.chromium.org/tast-tests/cros/local/bundles/cros/video/data/test-25fps.vp8 --vmodule=v4l2_stateful_video_decoder=3,*/media/gpu/v4l2/*=1,=0,video_decoder_pipeline=3 --enable-features=V4L2FlatStatefulVideoDecoder --gtest_filter='*.FlushAtEndOfStream' ) [1] https://www.kernel.org/doc/html/v5.15/userspace-api/media/v4l/dev-decoder.html#drain Bug: b:279980150 Change-Id: I11da082484bdb0334ef25fad5261e15ed57971db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713287 Reviewed-by: Hang Nguyen <hnt@chromium.org> Commit-Queue: Miguel Casas-Sanchez <mcasas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174892}
This is a reland of commit 2cdf03f Failing tests are fixed at https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/6171270 Original change's description: > [ios] Remove lock icon from the omnibox for secure pages > > The lock icon is being replaced by a new icon on other platforms. See > https://blog.chromium.org/2023/05/an-update-on-lock-icon.html for > details. > > On iOS, the decision is to remove the icon altogether. This CL removes > the lock icon from the omnibox for valid https URLs on iOS. It also adds > a kill switch to revert the removal if needed. > > Bug: 1463968 > Change-Id: I3ffbfd487ade420478f1dfa1143dd9480ebe538e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4675631 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1169998} Bug: 1463968 Change-Id: I1aa661504a2b4a61c5461fb169290eb09a8641f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4687046 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174893}
This CHECK was meant to verify the consistency of gpu driver bug workaround, but it was failing in fuzzing tests which break dependency assumptions between driver bug workarounds. This is fine. The CHECK was being too conservative. Bug: 1466418 Change-Id: I33eb5932812f38cf900677bbd427c3666904dff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712909 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Justin Novosad <junov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174894}
Help bubbles attached to menus are considered "annotations" and handled by a special event-forwarding system to allow closing the help bubble via mouse when the menu is showing (otherwise, the menu would lose focus and disappear). This was implemented assuming only a single help bubble attached to any given menu, but with tutorials that can attach to submenus, there can briefly be two simultaneous help bubbles, breaking this assumption. Now menus may have any number of annotations; events will be sent to each in turn, and the first one that reports that it handles the event will take precedence. This CL mostly changes from using a WeakAutoReset to a CallbackListSubscription, which is a more natural return value for adding an annotation callback anyway. A test is added to make sure that the double-bubble actually works. Change-Id: I5e49ae283832957f9e969a8266de07bea8096563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713887 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Mickey Burks <mickeyburks@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174895}
~17% failure rate for SegmentationPlatformUkmModelTest.RunUkmBasedModel: https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/Mac13%20Tests?limit=200 Bug: 1467530 Change-Id: I634bebfe418533d56baecb442b0f64daf2de67c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4711480 Reviewed-by: Salvador Guerrero Ramos <salg@google.com> Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Salvador Guerrero Ramos <salg@google.com> Owners-Override: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174896}
Also simplifies a number of tests. This is an attempt to break up the help bubble focus CL to try to suss out why we're having very specific test failures. Change-Id: I2c7e4f749d624a97a448f73a44557be837268a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712737 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Mickey Burks <mickeyburks@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174897}
It does not seems to occur today. Still, if someone tries one day, it ensures they won’t lose time debugging why it failed. Bug: None Change-Id: Ib606bf6f142c03b762a3776c1c4474a4f36d8950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4700965 Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174898}
Change-Id: I80d9d530a14c0d8f72bac44ec9345c2f040d50fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4711116 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Arcaro <adamta@google.com> Auto-Submit: Adam Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/main@{#1174899}
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/fe7f9005b1d8..f7cd2cdcbaa2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC chrome-brapp-engprod@google.com,edchin@google.com,sugoi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ied0d5260a2919f9280759252d50a638717533788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4715372 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1174900}
Add code to support migrating in both direction between legacy and optimised session storage to CWVWebView. This allow to convert the existing sessions to the new format when the feature is launched, to convert back if the feature is rolled back, and to have all the tests pass with the feature enabled. Bug: 1383087 Change-Id: Idea1054beaeae8a061ce992655356b5422bd09e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4695196 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174901}
Please wait for the CL crrev.com/c/4704930 submit. Bug: b/251258421 Change-Id: I03e972af1d5623101c685bfa9684b5934ba9246e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4708494 Reviewed-by: Daniel Andersson <dandersson@chromium.org> Commit-Queue: Hongyu Long <hongyulong@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174902}
Letting the visibility change out of band puts us in an inconsistent state where we think the container is hidden but its visibility is VISIBLE. Bug: 1462003 Change-Id: I7bb10aca78fdca27a864c05c51cf1237ec24b53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4711898 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174903}
Change-Id: I16bc05f7db2e34b9202594f0b7d5e4dd3f8b4eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4714350 Auto-Submit: Richard Wang <richardwa@google.com> Reviewed-by: Prakhar Asthana <pasthana@google.com> Commit-Queue: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/main@{#1174904}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202307250800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/n_IKjBqJMgdF-1Il_zxHSk_k-zHzNVSACMJhghpOPiUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC cros-essential-apps-dev@chromium.org,help-app@grotations.appspotmail.com,jomag@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/286118488 Tbr: help-app@grotations.appspotmail.com Change-Id: I3c2b4f2a163d8c406abca5f519c74df535cd763a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4715604 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1174905}
Plug a gap in file ownership rules where chrome/OWNERS oftentimes have to stamp Ash changes. Delegate to chrome/browser/ash/OWNERS instead. Change-Id: I1d47ca6dd3eb276afd763d3e20a06bbd7bf88f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712200 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174906}
We change the `blink::features::kSharedStorageAPIM117` flag to `blink::features::kSharedStorageAPIM118`, as the updates to the Shared Storage API that are bundled behind it are now targeted to ship in M118 instead. We also default-disable the flag for now. Bug: 1434529,1218540 Change-Id: I8645bc83457c0cb2309fbfc0db3c1e371883a12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718206 Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175100}
This CL changes how the clipboard history menu displays multi-file copied items. Previously the menu would attempt to show all filenames and inevitably get cut off; now, we just show the number of files that were copied. Before: https://screenshot.googleplex.com/9juHGGmHs9R4inG After: https://screenshot.googleplex.com/44PQX4xKgAs7ued Fixed: b/267694288 Change-Id: Ib006323d370fdedcce7ee166fe0546a3d7ed040d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712073 Reviewed-by: David Black <dmblack@google.com> Commit-Queue: Colin Kincaid <ckincaid@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175101}
Add a special case for browsers to quick return from `GetAppTypeForJson` when the apps cache isnt ready. Better fix coming soon. TESTED: DeskTemplateConversionTest.* Bug: b/292138056 Change-Id: I122425ddff1302c620d743ee0eb2d8d9fef73fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718391 Reviewed-by: Yanzhu Du <yzd@google.com> Commit-Queue: Avynn Donaghe <avynn@google.com> Cr-Commit-Position: refs/heads/main@{#1175102}
It is generally preferred to add attributes to the code instead of adding entries to the ignores.txt file. Add a comment to the top of the file saying so. Change-Id: Ic4df8e72f82d0687522765745aa441d2cca3ea91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718627 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175103}
This change changes the button bar to use cr-buttons in order to inherit the dynamic colors/properties for Jelly. Using cr-buttons will also allow for easier migrations in the future. Before, Jelly on: https://drive.google.com/file/d/1uaTz-tbeooaVGUupZJ-JeZtyuWSPLHVy/view?usp=drive_link&resourcekey=0-C2B1rGBSVCrGseMlUZ_IQA After, Jelly on: https://drive.google.com/file/d/1ZXnQlUGG9i1FaSi0mh_XsnSQL-Fv-5X7/view?usp=sharing&resourcekey=0-Ymf7c27Uq3ys2fjVGesCLA After, Jelly off (to show no regression): https://drive.google.com/file/d/10mGf3MmneeURGBurEYHcEQS1Tjjr-lp8/view?usp=sharing&resourcekey=0-_pUdfZLUsX2DwjgEZ_O1MA Test: Manually verified on DUT, provided videos. Current unit tests will still verify changes, as this was more of a refactor: //test/data/webui/cr_components/chromeos/multidevice_setup/ Bug: b/279667779 Change-Id: Ibd1af4c3941658915fc23b43e3298b50c73eb968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4704879 Commit-Queue: Crisrael Lucero <crisrael@google.com> Reviewed-by: Brittany Hartmire <bhartmire@google.com> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175104}
Bug: 1467309 Change-Id: I9a1de7c22368ee66e3fdea8c5004f7c7ece5d744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712729 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/main@{#1175105}
This crash seems to occur on resume or destroy so may be due to the view no longer being associated with a window. The stack doesn't give much more info and the referenced line doesn't correspond to a commit I can find. The crash is only seen Q and below and is predominantly on a specific device so there may be vendor customizations at play. Bug: 1156340 Change-Id: I5b7104a816001eadeee7f9a55f52a82fa595d67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4716929 Reviewed-by: Sky Malice <skym@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175106}
- The argument cros_args is replaced with individual ones as pytest doesn't support `nargs` options. - The file scp'd to the device is default to the user root, we need to grant permissions to all users for Chrome to read. - This CL also adds logic to boot up and shut down VM since there will be no other wrapper script to bootstrap the test. Bug: b/285346503 Change-Id: Ie612e4619a869bb79d846745a9f5dd296cc43150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712450 Commit-Queue: Hao Wu <haowoo@google.com> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175107}
Bug: b/285346503 Change-Id: I60fedc02d04c548a382ea8ddc8bec8b748b846f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712190 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Hao Wu <haowoo@google.com> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175108}
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/cdab1f0b6af2..1d3f19d60b1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com,salg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1459433,chromium:1467595 Tbr: salg@google.com No-Try: true Change-Id: Ib8c504b281908e9daf00a987d00cbcb7ffb75a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4719045 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1175109}
Printing the address of the ElementIdentifier implementation struct was useful when these systems were new, but provides no additional information now that the system is mature. On the other hand, since the identifier is printed out in error messages, including an arbitrary address can confuse LUCI clustering. This CL removes the address so that instead of ElementIdentifier printing to the debug stream as "ElementIdentifier ABCD1234ABCD1234 [kMyIdentifier]" They will print simply as: ElementIdentifier kMyIdentifier Change-Id: I52a92eb44045c48e514ed12819006b42011a907d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717453 Commit-Queue: Kuan Huang <kuanhuang@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Kuan Huang <kuanhuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175110}
This CL disables the following test: AwMetricsIntegrationTest#testPageLoadsEnableMultipleUploads Bug: 1467656 Change-Id: I29c5d3a0f56e04dea091c09e4d0cb4f7432545c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718492 Commit-Queue: Salvador Guerrero Ramos <salg@google.com> Owners-Override: Salvador Guerrero Ramos <salg@google.com> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175111}
Removes tether networks from mobile section grouping. Bug: b/290076393 Change-Id: Id2b4d9a7d3fb26ee2b46db4829662ae342c3264a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4706048 Reviewed-by: Joe Antonetti <joeantonetti@google.com> Reviewed-by: Chad Duffin <chadduffin@chromium.org> Auto-Submit: Rudransh Dikshit <rudranshd@google.com> Commit-Queue: Chad Duffin <chadduffin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175112}
Throughput tracker was being stopped in a case where it was never started. There would be problems in the compositor if that was the case. Test: none Bug: 1466918 Change-Id: I765db4498b0b5ff5ee9eadd687f80066dba3d012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717547 Reviewed-by: Daniel Andersson <dandersson@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175113}
This reverts commit b94ce17. Reason for revert: break internal builder because build/ is double referred by devtools. Original change's description: > [3pp] Implement 3pp for chromium/build/fuchsia/ > > It uploads the content into the chromium/fuchsia/test-scripts cipd > package, so it can be used to share with other repos. > > Unlike other implementations, `latest` returns the sha256 of the files > in the archive so that it can ignore most of the chromium changes but > focus only on the changes in the desired folder. > > A TODO is to remove the irrelevant files from the cipd package, but it > is less important. > > The 3pp should be automatically picked up by > https://ci.chromium.org/ui/p/chromium/builders/ci/3pp-linux-amd64-packager. > > FYI: 3pp is a system to upload packages to the cipd, since manual > uploading is disallowed. > https://chromium.googlesource.com/chromium/src/+/HEAD/docs/cipd_and_3pp.md > > Change-Id: I8e61569064fd74fd17d5c6e0c7c3c06b031b7bcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4633913 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Zijie He <zijiehe@google.com> > Reviewed-by: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/main@{#1163265} Change-Id: I7c5ee4382ff3deaafe7529b715c1207284e506ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718388 Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Zijie He <zijiehe@google.com> Cr-Commit-Position: refs/heads/main@{#1175114}
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/f7cd2cdcbaa2..94825c38c0fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC chrome-brapp-engprod@google.com,edchin@google.com,sugoi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I23ab11df12b8bac79222a8d8f0fd26577cc157cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717454 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1175115}
Add the button for the single icon selection in the button options menu. Bug: b/270969760 Test: Manual test to check the icons Change-Id: I2a0bae053f36a1c4da236ae2bb5c3a5ed9cb536f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712453 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Commit-Queue: Joseph Pang <pjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1175116}
This CL activates Welcome Tour windows by: 1. Make the help bubble container an activatable container. 2. Activate the help bubble if the bubble widget is a system modal widget. 3. Allow the help bubble container to gain activation from the app list bubble so that the app list bubble is not hidden when the help bubble shows. Verify this feature by interactive UI tests. Bug: b/287483131 Change-Id: Ibd425503cfab4e92869ab74fa517140df8ab471f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4701866 Reviewed-by: David Black <dmblack@google.com> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175117}
https://dawn.googlesource.com/dawn.git/+log/e3f5ea7e07c6..102525877d5b 2023-07-25 bclayton@google.com [tint] Move src/tint/writer options to include/tint 2023-07-25 bclayton@google.com [tint] Remove writer::IRTextGenerator 2023-07-25 enga@chromium.org Roll third_party/webgpu-cts/ f3351ce13..836a4733a (1 commit) 2023-07-25 bclayton@google.com [tint] Remove writer::Writer 2023-07-25 bclayton@google.com [tint] Remove ASTTextGenerator 2023-07-25 jrprice@google.com [tint] Fix test file name in GN build 2023-07-25 jrprice@google.com [ir][spirv-writer] Add benchmark 2023-07-25 jojwang@google.com Add duplicate libcxx source repo paths. 2023-07-25 bclayton@google.com [dawn] Fix all GCC warnings 2023-07-25 bclayton@google.com [tint] Remove src/tint/reader 2023-07-25 bclayton@google.com [tint] Shuffle transforms 2023-07-25 senorblanco@chromium.org GL: refactor explicit & implicit GetProcAddress. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1458042,chromium:1465961 Tbr: enga@google.com Change-Id: I37543267306b5f51d9d7a3063f08b8ac36664ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717955 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1175118}
Expose the current number of streams from CrasAudioHandler (without triggering a DBus), and then check the number of streams when SODA becomes available, and start recognizing. This allows System Live Captions to be enabled during video playback and start immediately recognizing as appropriate, rather than waiting for a pause/restart. AX-Relnotes: Improves System Live Captions at startup. Bug: b:285971536 Change-Id: I6831c99e5591916148cf4b3c41471c8c9b7438fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4703544 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by: Abigail Klein <abigailbklein@google.com> Reviewed-by: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#1175119}
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/15d24c08a585..5b605b242677 2023-07-25 jbabs@google.com Refactor std::function usage to absl::AnyInvocable for ZoneTransitionCallback > PiperOrigin-RevId: 550959839 > 2023-07-25 guogang@google.com internal update > PiperOrigin-RevId: 550729573 > 2023-07-24 anthonyrueda@google.com [Presence] Extend shared credential proto with int64 secret id field > PiperOrigin-RevId: 550661806 > If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/nearby-connections-chromium Please CC chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,nearby-chromeos-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi Bug: None Tbr: chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,nearby-chromeos-eng+autoroll@google.com Change-Id: I95a90a5ff1dcaabd6d0fecd38d90df8e1332a3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717794 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1175120}
Oops, I did it again. When I removed the last platform condition, the enable_rust_crash became gated on enable_all_rust_features, but that was only meant to override the disabled platforms. Bug: 1457505, 1368726 Change-Id: I774116d118eef6c5429149205e6fded1023a05a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718489 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175121}
Bug: b:280068539 Change-Id: I1c2c159d32f5771717f52bd14bf300de72e4b50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4704217 Commit-Queue: Hong Xu <xuhong@google.com> Reviewed-by: Leonid Baraz <lbaraz@chromium.org> Reviewed-by: Vignesh Shenvi <vshenvi@google.com> Cr-Commit-Position: refs/heads/main@{#1175122}
There is a bug that SharedDictionaryStorageInMemory can't override an existing dictionary. This is because SharedDictionaryStorageInMemory:: OnDictionaryWritten() method is using std::map's insert() method to insert a new dictionary to `dictionary_info_map_`. std::map's insert() doesn't insert a new element if the map contains an element with the same key. To fix this issue, this CL changes OnDictionaryWritten() method to use insert_or_assign() method. Bug: 1413922 Change-Id: I2e20d1148a3cc39adf5e66b7364594ff36869921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713906 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Patrick Meenan <pmeenan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175123}
Add button action data and getActionsForButtonCustomization in provider. Bug: b/241965717 Test: browser_tests Change-Id: I81496a235882533446ff9c37216f022eced9a7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712389 Reviewed-by: David Padlipsky <dpad@google.com> Commit-Queue: Yuhan Yang <yyhyyh@google.com> Cr-Commit-Position: refs/heads/main@{#1175124}
Current Problem: currently the stop_callback stored in the ediaStreamCaptureIndicator::WebContentsDeviceUsage keyed by device_id. Because the device_id is not unique, there are at least two problems with this: (1) the stop_callback can be easily overwritten by another capturing that captures the same device. This happens for both getUserMedia and getDisplayMedia. (2) when there is both audio_device and video_device, it is hard to decide which/what id to use. a global index can solve both problems. Solution: A g_stop_callback_id is used to uniquely identify each stop_callback. Each MediaStreamCaptureIndicator::UIDelegate gets its own unique stop_callback_id from g_stop_callback_id and used when adding and removing devices. Bug=b:292539836 TEST="autoninja -C out/Test chrome/test:browser_tests && out/Test/browser_tests --gtest_filter=InteractionBetweenGetAllScreensMediaAndGetDisplayMediaTest.*" Change-Id: I2cd9200370025e82965709a7510c9458da85a5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4703375 Commit-Queue: Charles Zhao <charleszhao@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175125}
Additionally, moved the test under the `os_apps_page/app_notifications_page/` folder to mirror the app folder structure. gtest_filter="*OsAppsPageAppNotificationsPageAppNotificationsSubpage*" Bug: b/270728282 Test: browser_tests -- Change-Id: Ifb4d5eacd46733b37d527007655dc9a87a2517bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4679898 Commit-Queue: Ruma Kesh <rkesh@google.com> Reviewed-by: Wes Okuhara <wesokuhara@google.com> Cr-Commit-Position: refs/heads/main@{#1175126}
pull bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
https://chromium.googlesource.com/external/github.com/WebKit/Speedometer.git/+log/7b1b81ee1319..8d67f28d0281 $ git log 7b1b81ee1..8d67f28d0 --date=short --no-merges --format='%ad %ae %s' 2024-03-07 issackjohn Fix Cross-platform issue with npm script (#397) 2024-03-06 markus.stange Avoid :has selector in CSS. (#395) 2024-03-05 94007365+lpardosixtosMs Update license dates, add Microsoft (#393) 2024-03-05 felash Run `npm audit fix` on charts and editors (#390) 2024-03-04 felash Enable source maps in charts and editors (#391) 2024-03-04 94007365+lpardosixtosMs Update Testing.md to include Microsoft Edge (#392) 2024-03-01 tkober Revert "Todomvc-vue: source-map creation (#386)" (#388) 2024-03-01 tkober Todomvc-vue: source-map creation (#386) 2024-03-01 tkober run format command from root (#387) 2024-02-29 rniwa Update about.html to link to each test's GitHub directories instead of directly linking to README.md files. (#384) 2024-02-29 issackjohn Fix Hidden dropdown menus (#376) 2024-02-29 briangrinstead Remove experimental note from README.md (#361) 2024-02-29 camillobruni Add warmup and step delay to developer UI (#323) 2024-02-28 94007365+lpardosixtosMs Enable local testing in Edge (#382) 2024-02-27 issackjohn Make about.html text reflect currently enabled workloads (#381) 2024-02-27 camillobruni Update General Instructions (#377) 2024-02-20 tkober Rebuild workloads (#375) 2024-02-17 felash Make the github action linter step fail in the case of issues (#374) 2024-02-15 rniwa Add the source map for Angular TodoMVC build. (#332) 2024-02-09 briangrinstead Update about.html (#372) 2024-02-08 felash jQuery workloads: use :nth-child() in a querySelector call in each iteration (#367) 2024-02-02 camillobruni Add separate about.html and instructions.html (#359) Created with: roll-dep src/third_party/speedometer/v3.0 Change-Id: I7deb369efd81d49e145e8351c0ed5c7503732ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5362601 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Issack John <issackjohn@microsoft.com> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1271625}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )