Merged
Conversation
It's in tree now, so this code is not needed and confusing. --------- Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
…9630) - Minimizes the calls to xptiRegisterStream() - Intializes all the necessary streams and creates events needed by SYCL in one location --------- Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>
Adds missing event handling to `urEnqueueUSMPrefetch` in the Native CPU adapter. This aims to fix random fails in `SYCL/USM/dep_events.cpp`. Also removes unneeded call to `urEventWait`.
llvm-diff changes: * libspirv-amdgcn--amdhsa.bc has no change. * libspirv-nvptx64--nvidiacl.bc has instruction order changes. Change of get_local_size out-of-bound value will be fixed by bce14c6. * libspirv-native_cpu.bc has new symbols _Z25__spirv_BuiltInSubgroupIdv and __mux_get_sub_group_id.
`${Python3_EXECUTABLE}` is what is set by FindPython3 and is what is
used everywhere else.
`${PYTHON_EXECUTABLE}` may be unset depending, causing the build to
fail.
This failure case gets hit when compiling under NixOS for example
There's a few instances of `PYTHON_EXECUTABLE` left in upstream LLVM,
though I haven't verified whether it builds properly with those changed
to `Python3_EXECUTABLE`, so they're untouched here.
In #17408, NativeCPU became a target in order to be able to pick the ABI for its own libclc functions consistently, without having targets affect this. This was, and is, required to be able to use libclc independent of target and target options. However, it breaks some calls into libc. Therefore, this PR allows the calling convention to be explicitly specified, ensures it is specified for any libclc functions, and ensures it is not specified for any libc functions. Fixes the SYCL-E2E acos, cmath, and exp-std-complex tests.
Scheduled drivers uplift --------- Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Sarnie, Nick <nick.sarnie@intel.com>
This PR disables dead argument elimination for free function kernels. When using a free function kernel, the user sets the arguments manually using `handler::set_arg` but if certain arguments are optimized away in case they are not used, the implementation needs to be aware of this and remove the relevant `set_arg` calls. Instead, its much more feasible to just disable dead arg elimination in this case. --------- Co-authored-by: Alexey Sachkov <alexey.sachkov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )