Fix uninstall failing when Wave Terminal config not found#18
Merged
Conversation
Contributor
Review ChecklistPlease ensure the following before merging: Code Quality
Testing
Documentation
GitHub Copilot has been requested to review this PR. |
Co-authored-by: Qbandev <8140029+Qbandev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix uninstall commands not working
Fix uninstall failing when Wave Terminal config not found
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes uninstall failures when Wave Terminal isn’t installed (or its config dir can’t be detected) by making install.sh’s run_uninstall() skip widget removal gracefully—matching the standalone uninstall.sh behavior.
Changes:
- Add a guard in
run_uninstall()to detect missingWAVETERM_CONFIG. - Emit a warning and continue uninstall steps instead of attempting to access
widgets.jsonwith an empty config path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Qbandev
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
run_uninstall()function ininstall.shattempts to use$WAVETERM_CONFIG/widgets.jsonwithout checking ifWAVETERM_CONFIGis empty, causing failures when Wave Terminal is not installed or its config directory is missing. The standaloneuninstall.shalready handles this correctly.Changes
run_uninstall()to matchuninstall.shbehavior:This synchronizes both uninstall code paths (
wave-notes-setup --uninstallandwave-notes-uninstall).Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.