Skip to content

Conversation

@Eric-Arellano
Copy link
Collaborator

Closes #154. Builds on top of @Gyan-max 's great work in #2827. All images now follow a consistent naming scheme.

Co-Authored-By: Gyan Ranjan <76723725+Gyan-max@users.noreply.github.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

@Eric-Arellano
Copy link
Collaborator Author

Hey @Gyan-max, I am opening this in lieu of #2827. I added you as a co-author so that you still get credit with Git :)

I opened this because I really want to make sure your good work is applied before I make some very disruptive changes to how we set up images, like #2930. My PRs were going to result in a lot of merge conflicts with your PR, so I wanted to land your change before that.

Thank you for your work on this all! I've been wanting to fix this issue for over a year, so I'm excited that you made it happen!

By the way, I recommend still following the instructions I put in #2827 (comment) to fix your main branch in your fork. That is going to give you issues with future contributions.

@Eric-Arellano Eric-Arellano mentioned this pull request Apr 4, 2025
4 tasks
@Gyan-max
Copy link
Contributor

Gyan-max commented Apr 4, 2025

Hi @Eric-Arellano,

Thanks for pushing this forward and adding me as co-author. I’ll fix my main branch. Excited to see this land, let me know if I can help more!

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Awesome job @Gyan-max with the new images organization 🚀

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 8a2ee1a Apr 4, 2025
4 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/organize-images branch April 4, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Organize images better

4 participants