Fix num_qubits() and num_clbits() methods#122
Merged
doichanj merged 1 commit intoOct 14, 2025
Conversation
The num bits methods were incorrectly querying the target stored with the circuit, when present, for the number of bits instead of the actual circuit attributes. This commit fixes this issue so the circuit bit counts are correctly returned. There is a larger question around why the circuit is locally storing the bit counts instead of just querying the inner qiskit circuit object. But for just fixing this issue I kept the change minimal rather than removing the protected attribute. We can do that in a follow up if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The num bits methods were incorrectly querying the target stored with the circuit, when present, for the number of bits instead of the actual circuit attributes. This commit fixes this issue so the circuit bit counts are correctly returned.
There is a larger question around why the circuit is locally storing the bit counts instead of just querying the inner qiskit circuit object. But for just fixing this issue I kept the change minimal rather than removing the protected attribute. We can do that in a follow up if needed.
Details and comments