Keep file logging tracebacks uncolored#149
Open
dicnunz wants to merge 2 commits into
Open
Conversation
Author
|
Pushed Verified:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87.
IssueHunt bounty: https://issuehunt.io/r/Qix-/better-exceptions/issues/87
This is a fresh, tested replacement for the stale direction in #99. That PR is still dirty/stale and had requested changes; this keeps the scope limited to the logging color behavior.
Reproduction
When a logger has both a stderr StreamHandler and a FileHandler, logging formats the same LogRecord for each handler. If the stream handler formats first, logging caches record.exc_text with ANSI color codes, and the file handler can reuse that colored cached traceback.
Changes
Tests
Passed:
Not fully completed locally: