Merged
Conversation
Contributor
Contributor
Author
No, I'm afraid not. I thought that was disallowed by the spec, but I see was wrong 😣 Sorry about that. I'm not using the library in my project anymore so I don't have an immediate need to work on that myself. You're very welcome to fork my branch to add support, of course. |
Contributor
Contributor
Author
|
Done. Thanks very much! |
ccbea79 to
a6c9763
Compare
It was a duplicate of another test earlier in the file, and wasn't testing the "no alpha" case.
a6c9763 to
a2ea739
Compare
Owner
|
Thanks :) |
Owner
|
Published as |
Contributor
|
You're very welcome @Qix- , thank you for making this! Now that I'm looking at it again, I think I should have used |
Owner
|
PR welcome. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost exactly the same as @htunnicliff's excellent PR #55, but just for the RGB case instead of HSL. It adds support for values like:
The motivation for this was that Chrome's developer tools now uses that form of notation for RGB colors, and I got bitten by blindly copying and pasting one into my CSS 😅