Skip to content

Conversation

@2ndalpha
Copy link
Member

@2ndalpha 2ndalpha commented Jun 1, 2022

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (Changed implementation, but existing functionality and APIs are not changed)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • Changes have been reviewed by at least one other engineer

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #333 (332ae65) into master (d1d37e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files          12       12           
  Lines         656      656           
  Branches      136      136           
=======================================
  Hits          500      500           
  Misses        155      155           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d37e0...332ae65. Read the comment docs.

@2ndalpha 2ndalpha requested a review from boxmein June 1, 2022 08:52
@2ndalpha 2ndalpha marked this pull request as ready for review June 1, 2022 08:52
@2ndalpha 2ndalpha merged commit d9cf45f into master Jun 1, 2022
@2ndalpha 2ndalpha deleted the siim_sinon branch June 1, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants