Skip to content

chore: remove cross-fetch#722

Merged
raluik merged 9 commits intomasterfrom
siim/rm-cross-fetch
Aug 14, 2024
Merged

chore: remove cross-fetch#722
raluik merged 9 commits intomasterfrom
siim/rm-cross-fetch

Conversation

@2ndalpha
Copy link
Member

@2ndalpha 2ndalpha commented Aug 13, 2024

Stopped using cross-fetch.
Now NodeJS has built-in support for fetch (I bumped the minimum required version to 18).

Unfortunately we still need cross-fetch in tests.
See jsdom/jsdom#1724

Checklist

  • Code is covered with tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (5ffcb60) to head (afa5115).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   82.36%   82.31%   -0.05%     
==========================================
  Files          23       23              
  Lines         788      786       -2     
  Branches      136      137       +1     
==========================================
- Hits          649      647       -2     
+ Misses        138      130       -8     
- Partials        1        9       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2ndalpha 2ndalpha marked this pull request as ready for review August 13, 2024 14:42
@2ndalpha 2ndalpha requested a review from raluik August 13, 2024 14:42
Copy link
Contributor

@raluik raluik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's update the Node version in other GitHub workflows as well.

@2ndalpha 2ndalpha requested a review from raluik August 14, 2024 09:21
@raluik raluik added this pull request to the merge queue Aug 14, 2024
Merged via the queue into master with commit 076236a Aug 14, 2024
@raluik raluik deleted the siim/rm-cross-fetch branch August 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants