Skip to content

fix: replace Promise<any> with SuccessResponse in line mutations#835

Merged
2ndalpha merged 1 commit intomasterfrom
fix/line-promise-any-return-types
Mar 30, 2026
Merged

fix: replace Promise<any> with SuccessResponse in line mutations#835
2ndalpha merged 1 commit intomasterfrom
fix/line-promise-any-return-types

Conversation

@2ndalpha
Copy link
Copy Markdown
Member

@2ndalpha 2ndalpha commented Mar 26, 2026

Summary

  • Replace all 12 occurrences of Promise<any> (6 return types + 6 type assertions) in line.ts with Promise<SuccessResponse>
  • Matches the existing pattern used in user.ts for similar API mutations
  • Type-only change, no runtime behavior affected

Test plan

  • yarn build succeeds
  • All 294 tests pass

@2ndalpha
fix: replace Promise<any> with SuccessResponse in line mutation funct…
68acc50 
…ions

All six line mutation functions (update, enable, disable, archive,
unarchive, deleteLine) returned Promise<any>, undermining type safety
for consumers. Replaced with Promise<SuccessResponse> to match the
existing pattern used in user.ts.
@2ndalpha 2ndalpha requested a review from KonradPaluch March 26, 2026 13:50
@2ndalpha 2ndalpha added this pull request to the merge queue Mar 30, 2026
Merged via the queue into master with commit da1858b Mar 30, 2026
10 checks passed
@2ndalpha 2ndalpha deleted the fix/line-promise-any-return-types branch March 30, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KonradPaluch KonradPaluch KonradPaluch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@2ndalpha @KonradPaluch