Open
Conversation
Contributor
|
Thanks for the PRs hopefully I'll have some time to review this afternoon. |
Contributor
|
Seems the gates aren't rendering and blulectric cables don't seem to talk multipart to multipart I haven't had a chance to look into this yet. |
Contributor
Author
|
Yah i noticed that same issue with the gates, the only thing I found so far when trying to debug it was maybe it's the render type? I tried setting the gates to use the translucent render type but that made them render weird when not in a multipart, and it didn't seem to fix the issue. All I know for sure is for some reason it's not adding the quads |
still need to fix regular lighting though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a couple issues I found with multipart blocks, still need to figure out why not all multipart blocks want to render
Also made Gates able to be multiparts, though I haven't made any of them use the multipart item yet because of #636. #636 will probably also conflict with this, so should probably merge this first