[3.x] Refactoring MailEclipse Package #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReeceM
added
enhancement
ReeceM
commented
Nov 1, 2020
Collaborator
Author
ReeceM
left a comment
ReeceM
left a comment
There was a problem hiding this comment.
Some fixes still need to be changed, one issue found in the way of the merge from master
Collaborator
Author
|
Actually, looking at all the changes being made, I could split this into a bunch of PR's |
Collaborator
Author
|
Just a note so that it isn't assumed it's abandoned, currently just handling a few things and will be able to come back to this update. As I do feel it should help add new features as contributors can be given a clear idea as to where to add features |
ReeceM
changed the title
Collaborator
Author
|
Cool :) I'll merge merge it to master for testing purposes, I do think I may have broken stuff. So I won't tag anything till it's fixed and running smooth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will contain the initial set of refactoring changes that would encourage an easier on-boarding of new contributors.
It will also hopefully make it easier to get unit tests going on the project so that the state is known when new people add/remove things :)
Based on #129
Will be a draft for now as the new edits are made so that the PR isn't merged, any new updates to master I will add to my branch, so please feel free to continue accepting PRs if there are any.