Merged
Conversation
Contributor
|
Can you rebase this one? |
ikrestov
force-pushed
the
fix/numeric-parsing
branch
from
c405cba to
6df0e30
Compare
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
Should be reviewed/ merged after #203 is resolved.
This introduces an assert, to make sure column name/value lists match.
c405cba#diff-779da9398d8444388b74dd3391171530e14248d77cf4e4526eb66b901695079fR205
c405cba#diff-c74276bcbe3d49e8387a71e14066fac0ddc12564222793e2286982ca9b596426R299
This is very much a hack, as with it incorrectly parses
2 +2, which should be parsed as[Number,Plus,Number], but would be parsed as[Number, Number], but current state is much worse as any negative number-1would not be handled correctly.