feat(console-migration): add banner to migrate console to new-console#2608
feat(console-migration): add banner to migrate console to new-console#2608RemiBonnet merged 8 commits intostagingfrom
Conversation
…egrate into LayoutPage for new console redirection
…nsure proper redirection to new console URL
…t for console migration prompt
…to outline for improved UI consistency
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2608 +/- ##
===========================================
+ Coverage 47.47% 48.68% +1.20%
===========================================
Files 1231 843 -388
Lines 23050 17882 -5168
Branches 6851 5330 -1521
===========================================
- Hits 10942 8705 -2237
+ Misses 10045 7555 -2490
+ Partials 2063 1622 -441
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d layout consistency
| onConfirm={handleConsoleMigration} | ||
| onClose={() => setIsConsoleMigrationBannerDismissed(true)} |
There was a problem hiding this comment.
Could be interesting to have posthog events to know how many users dismissed or confirmed. Wdyt?
| const { user: userToken } = useAuth() | ||
| const { data: user } = useUserAccount() | ||
| const { mutateAsync, isLoading: loading } = useEditUserAccount() | ||
| const { useNewConsoleByDefault, setUseNewConsoleByDefault } = useConsoleRedirectPreference() |
There was a problem hiding this comment.
Having variable names starting with use is quite disturbing as only hooks are supposed to have this prefix.
…ty and consistency
…ration prompt interactions in LayoutPage
…function and update analytics tracking for console migration prompts
|
🎉 This PR is included in version 1.302.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release