Skip to content

feat(console-migration): add banner to migrate console to new-console#2608

Merged
RemiBonnet merged 8 commits intostagingfrom
feat/console-v5-migration
Apr 21, 2026
Merged

feat(console-migration): add banner to migrate console to new-console#2608
RemiBonnet merged 8 commits intostagingfrom
feat/console-v5-migration

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 20, 2026

Summary

  • Add the first part of the console migration and a feature flag enabled only for our team for now (available here)
  • Need an second PR to add a toggle in the user modal after rebasing this one⁠

Screenshots / Recordings

Screenshot 2026-04-20 at 15 46 06 Screenshot 2026-04-20 at 15 46 21

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

…egrate into LayoutPage for new console redirection
@RemiBonnet RemiBonnet marked this pull request as ready for review April 20, 2026 13:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 58.57143% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.68%. Comparing base (77ec122) to head (64f793a).
⚠️ Report is 5 commits behind head on staging.

Files with missing lines Patch % Lines
...rect-preference/use-console-redirect-preference.ts 45.23% 19 Missing and 4 partials ⚠️
...ages/layout/src/lib/ui/layout-page/layout-page.tsx 77.27% 3 Missing and 2 partials ⚠️
...layout/src/lib/ui/layout-page/layout-page.utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2608      +/-   ##
===========================================
+ Coverage    47.47%   48.68%   +1.20%     
===========================================
  Files         1231      843     -388     
  Lines        23050    17882    -5168     
  Branches      6851     5330    -1521     
===========================================
- Hits         10942     8705    -2237     
+ Misses       10045     7555    -2490     
+ Partials      2063     1622     -441     
Flag Coverage Δ
unittests 48.68% <58.57%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +235 to +236
onConfirm={handleConsoleMigration}
onClose={() => setIsConsoleMigrationBannerDismissed(true)}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be interesting to have posthog events to know how many users dismissed or confirmed. Wdyt?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea e060f23 !

const { user: userToken } = useAuth()
const { data: user } = useUserAccount()
const { mutateAsync, isLoading: loading } = useEditUserAccount()
const { useNewConsoleByDefault, setUseNewConsoleByDefault } = useConsoleRedirectPreference()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having variable names starting with use is quite disturbing as only hooks are supposed to have this prefix.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed be10e45

@RemiBonnet RemiBonnet changed the title feat(console-migration): add banner to migrate console to new-consle feat(console-migration): add banner to migrate console to new-console Apr 21, 2026
…function and update analytics tracking for console migration prompts
@RemiBonnet RemiBonnet requested a review from rmnbrd April 21, 2026 07:04
@RemiBonnet RemiBonnet merged commit 1583a78 into staging Apr 21, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/console-v5-migration branch April 21, 2026 13:45
@RemiBonnet
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.302.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants