Skip to content

fix(console-redirect): update console preference handling to use cookies exclusively#2622

Merged
RemiBonnet merged 1 commit intostagingfrom
fix/console-v5-migration-redirect-5
Apr 22, 2026
Merged

fix(console-redirect): update console preference handling to use cookies exclusively#2622
RemiBonnet merged 1 commit intostagingfrom
fix/console-v5-migration-redirect-5

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review April 22, 2026 15:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.80%. Comparing base (f376b56) to head (cf43ea6).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...rect-preference/use-console-redirect-preference.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2622      +/-   ##
===========================================
- Coverage    49.02%   48.80%   -0.23%     
===========================================
  Files          841      843       +2     
  Lines        17598    17902     +304     
  Branches      5228     5335     +107     
===========================================
+ Hits          8628     8737     +109     
- Misses        7369     7537     +168     
- Partials      1601     1628      +27     
Flag Coverage Δ
unittests 48.80% <71.42%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet enabled auto-merge (squash) April 22, 2026 15:54
@RemiBonnet RemiBonnet disabled auto-merge April 22, 2026 15:55
@RemiBonnet RemiBonnet merged commit 17b4135 into staging Apr 22, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/console-v5-migration-redirect-5 branch April 22, 2026 15:55
@RemiBonnet
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.302.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant