fix(console-redirect): update console preference handling to use cookies exclusively

libs/shared/iam/feature/src/lib/use-console-redirect-preference/use-console-redirect-preference.spec.ts

@@ -220,14 +220,30 @@ describe('useConsoleRedirectPreference', () => {
     expect(getNewConsoleUrl('https://console.qovery.com/organization')).toBe('https://new-console.qovery.com/')
   })
 
-  it('should read the preference from local storage first', () => {
+  it('should read the preference from the shared cookie only', () => {
+    // localStorage is per-origin and would be stale across console/new-console subdomains.
+    // Regardless of what it contains, the cookie is the only source of truth.
     localStorage.setItem('qovery-console-preference', 'new')
     document.cookie = 'qovery-console-preference=legacy; Path=/'
 
-    expect(getStoredConsolePreference()).toBe('new')
+    expect(getStoredConsolePreference()).toBe('legacy')
+  })
+
+  it('should default to legacy when the cookie is not set', () => {
+    localStorage.setItem('qovery-console-preference', 'new')
+
+    expect(getStoredConsolePreference()).toBe('legacy')
+  })
+
+  it('should purge any stale local storage preference on read', () => {
+    localStorage.setItem('qovery-console-preference', 'new')
+
+    getStoredConsolePreference()
+
+    expect(localStorage.getItem('qovery-console-preference')).toBeNull()
   })
 
-  it('should fallback to cookies when local storage is empty', () => {
+  it('should return the preference stored in the cookie', () => {
     document.cookie = 'qovery-console-preference=new; Path=/'
 
     expect(getStoredConsolePreference()).toBe('new')

libs/shared/iam/feature/src/lib/use-console-redirect-preference/use-console-redirect-preference.ts

@@ -2,7 +2,8 @@ import { useCallback, useEffect, useState } from 'react'
 
 export type ConsolePreference = 'legacy' | 'new'
 
-const CONSOLE_PREFERENCE_STORAGE_KEY = 'qovery-console-preference'
+// Legacy key kept only to purge stale values written before the cookie-only migration.
+const LEGACY_CONSOLE_PREFERENCE_STORAGE_KEY = 'qovery-console-preference'
 const CONSOLE_PREFERENCE_COOKIE_KEY = 'qovery-console-preference'
 const CONSOLE_PREFERENCE_CHANGED_EVENT = 'qovery-console-preference-changed'
 const LEGACY_CONSOLE_BYPASS_QUERY_PARAM = 'legacy'
@@ -34,12 +35,26 @@ function readCookieValue(cookieName: string): string | null {
   return cookie ? decodeURIComponent(cookie) : null
 }
 
+// localStorage is per-origin and does NOT propagate between `console.qovery.com` and
+// `new-console.qovery.com`. Any value stored under this key by older builds can leave
+// users ping-ponging across subdomains, so we proactively remove it on read.
+function purgeLegacyLocalStorageKey() {
+  if (typeof window === 'undefined') {
+    return
+  }
+  try {
+    window.localStorage.removeItem(LEGACY_CONSOLE_PREFERENCE_STORAGE_KEY)
+  } catch {
+    // ignore (Safari private mode, quota, ...)
+  }
+}
+
 function persistConsolePreference(preference: ConsolePreference) {
   if (typeof window === 'undefined') {
     return
   }
 
-  localStorage.setItem(CONSOLE_PREFERENCE_STORAGE_KEY, preference)
+  purgeLegacyLocalStorageKey()
 
   const domain = getCookieDomain(window.location.hostname)
   document.cookie = `${CONSOLE_PREFERENCE_COOKIE_KEY}=${encodeURIComponent(preference)}; Path=/; Max-Age=${ONE_YEAR_IN_SECONDS}; SameSite=Lax${
@@ -53,11 +68,9 @@ export function getStoredConsolePreference(): ConsolePreference {
     return 'legacy'
   }
 
-  const localStoragePreference = localStorage.getItem(CONSOLE_PREFERENCE_STORAGE_KEY)
-
-  if (isConsolePreference(localStoragePreference)) {
-    return localStoragePreference
-  }
+  // The cookie (scoped to `.qovery.com`) is the only source of truth that works across
+  // `console.qovery.com` and `new-console.qovery.com`. localStorage is intentionally ignored.
+  purgeLegacyLocalStorageKey()
 
   const cookiePreference = readCookieValue(CONSOLE_PREFERENCE_COOKIE_KEY)
 
@@ -180,18 +193,10 @@ export function useConsoleRedirectPreference() {
       setPreferredConsoleState(isConsolePreference(preference) ? preference : getStoredConsolePreference())
     }
 
-    const syncConsolePreferenceFromStorage = (event: StorageEvent) => {
-      if (event.key === CONSOLE_PREFERENCE_STORAGE_KEY) {
-        syncConsolePreference()
-      }
-    }
-
     window.addEventListener(CONSOLE_PREFERENCE_CHANGED_EVENT, syncConsolePreference)
-    window.addEventListener('storage', syncConsolePreferenceFromStorage)
 
     return () => {
       window.removeEventListener(CONSOLE_PREFERENCE_CHANGED_EVENT, syncConsolePreference)
-      window.removeEventListener('storage', syncConsolePreferenceFromStorage)
     }
   }, [])