Skip to content

feat(request-integration): let users request missing blueprints and secret manager integration - #2934

Merged
rmnbrd merged 6 commits into
stagingfrom
feat/request-missing-integration-feedback
Sep 4, 2026
Merged

feat(request-integration): let users request missing blueprints and secret manager integration#2934
rmnbrd merged 6 commits into
stagingfrom
feat/request-missing-integration-feedback

Conversation

@jul-dan

@jul-dan jul-dan commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Issue: QOV-2230

Frontend

  • "New service" page (service-new.tsx):
    • "Request blueprint" button in the Blueprints section header (next to the search input).
    • Additional "Request blueprint" button in the empty state ("No blueprints found").
    • New BlueprintMissingModal component (textarea: "Which blueprint is missing?").
  • Cluster creation flow, Add-ons step (step-addons.tsx) and Cluster Settings > Add-ons (addons.tsx):
    • "Request integration" button next to "Add secret manager".
    • New shared SecretManagerMissingModal component.
  • UI fix: button height aligned with neighboring elements (search input / dropdown trigger).

Tracking (PostHog)

  • Event blueprint-missing-feedback — payload: message, organization_id, cloud_provider.
  • Event cluster-secret-manager-missing-feedback — payload: message, organization_id, cluster_id, source (creation-flow | settings).
  • Standard insights created (Trends, breakdown by message, internal accounts filtered out):
    • Blueprint requests
    • Secret manager integration requests

Screenshots / Recordings

image image image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Lets users request missing blueprints and secret manager integrations (QOV-2230) instead of leaving them stuck when what they need isn't listed. Adds "Request blueprint" buttons on the New Service page and "Request integration" buttons on the cluster creation Add-ons step and Cluster Settings > Add-ons, each opening a feedback modal. Also aligns button heights with the surrounding search inputs and dropdown triggers.

The blueprint modal pre-fills the message with the current search term and enables Send request right away when that term is already filled; the "No blueprints found" empty state shows a request button even when no blueprints are compatible with the cluster.

Tracking

  • Records blueprint-missing-feedback with message, organization_id, and cloud_provider.
  • Records cluster-secret-manager-missing-feedback with message, organization_id, cluster_id, and source (creation-flow or settings).

Written for commit 89f9131. Summary will update on new commits.

Review in cubic

…tions

Adds a "Request blueprint"/"Request integration" CTA and feedback modal
on the Service creation page, the cluster creation addons step, and
cluster settings > Add-ons, so users can signal a missing item instead
of silently bouncing. Submissions are tracked via PostHog
(blueprint-missing-feedback, cluster-secret-manager-missing-feedback).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@nx-cloud

nx-cloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 89f9131

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 59s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 13s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 23s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 6s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-04 07:08:53 UTC

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.21%. Comparing base (1c15da0) to head (89f9131).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...ns/secret-manager/secret-manager-missing-modal.tsx 0.00% 8 Missing ⚠️
.../cluster-creation-flow/step-addons/step-addons.tsx 85.71% 1 Missing ⚠️
...rvices/feature/src/lib/service-new/service-new.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2934      +/-   ##
===========================================
+ Coverage    49.68%   51.21%   +1.52%     
===========================================
  Files         1302      840     -462     
  Lines        28022    21029    -6993     
  Branches      8179     6395    -1784     
===========================================
- Hits         13924    10769    -3155     
+ Misses       11761     8408    -3353     
+ Partials      2337     1852     -485     
Flag Coverage Δ
unittests 51.21% <66.66%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread libs/domains/services/feature/src/lib/service-new/service-new.tsx
jul-dan and others added 4 commits September 3, 2026 17:56
…nager/secret-manager-missing-modal.tsx

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
…ep-addons/step-addons.tsx

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
…ssing-modal/blueprint-missing-modal.tsx

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
…ible

BlueprintSection returned null before rendering anything once
compatibleBlueprints was empty, hiding the "Request blueprint" CTA
exactly when users have no matching blueprint to find. Let it fall
through to the existing empty state instead.

Also trigger form validation on mount in BlueprintMissingModal so the
submit button isn't disabled when the modal opens with an already
valid, prefilled search term (react-hook-form doesn't validate on
mount under mode: 'onChange').

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jul-dan jul-dan changed the title feat: let users request missing blueprints and secret manager integra… feat(request-integration): let users request missing blueprints and secret manager integration Sep 3, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

…ssing-modal/blueprint-missing-modal.tsx

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@rmnbrd
rmnbrd enabled auto-merge (squash) September 4, 2026 08:49

@rmnbrd rmnbrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@rmnbrd
rmnbrd merged commit cf23dce into staging Sep 4, 2026
15 checks passed
@rmnbrd
rmnbrd deleted the feat/request-missing-integration-feedback branch September 4, 2026 08:51
@RemiBonnet

Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.348.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants