Skip to content

feat(clusters): add the cloud provider selection view#1697

Merged
RemiBonnet merged 10 commits intostagingfrom
FRT-1306-add-the-cloud-provider-selection-view-before-entering-the-cluster-creation-flow
Oct 2, 2024
Merged

feat(clusters): add the cloud provider selection view#1697
RemiBonnet merged 10 commits intostagingfrom
FRT-1306-add-the-cloud-provider-selection-view-before-entering-the-cluster-creation-flow

Conversation

@ctjhoa
Copy link
Copy Markdown
Contributor

@ctjhoa ctjhoa commented Sep 27, 2024

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There are two hard problems in computer science: naming things, cache invalidation and off-by-1 errors

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Sep 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 56bbba8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@ctjhoa
Copy link
Copy Markdown
Contributor Author

ctjhoa commented Sep 27, 2024

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(clusters): add the cloud provider selection view - 2024-09-27T12:09:47Z

Another comment will be posted when deployments are finished

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console

@ctjhoa ctjhoa force-pushed the FRT-1306-add-the-cloud-provider-selection-view-before-entering-the-cluster-creation-flow branch from bc8384d to 804d0ff Compare September 27, 2024 12:57
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 16.84211% with 79 lines in your changes missing coverage. Please review.

Project coverage is 52.69%. Comparing base (7c08874) to head (56bbba8).
Report is 5 commits behind head on staging.

Files with missing lines Patch % Lines
.../lib/feature/page-new-feature/page-new-feature.tsx 2.63% 37 Missing ⚠️
...rs-create-feature/page-clusters-create-feature.tsx 16.66% 8 Missing and 2 partials ⚠️
...n-guide-modal/cluster-installation-guide-modal.tsx 0.00% 6 Missing ⚠️
...ture/step-summary-feature/step-summary-feature.tsx 0.00% 5 Missing and 1 partial ⚠️
libs/shared/ui/src/lib/components/icon/icon.tsx 0.00% 5 Missing ⚠️
...re/step-features-feature/step-features-feature.tsx 25.00% 3 Missing ⚠️
...ture/step-general-feature/step-general-feature.tsx 50.00% 2 Missing ⚠️
...tep-kubeconfig-feature/step-kubeconfig-feature.tsx 0.00% 2 Missing ⚠️
.../step-resources-feature/step-resources-feature.tsx 50.00% 2 Missing ⚠️
...b/ui/placeholder-no-rules/placeholder-no-rules.tsx 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1697      +/-   ##
===========================================
- Coverage    53.13%   52.69%   -0.45%     
===========================================
  Files          951      948       -3     
  Lines        12782    12680     -102     
  Branches      3683     3662      -21     
===========================================
- Hits          6792     6682     -110     
- Misses        4736     4752      +16     
+ Partials      1254     1246       -8     
Flag Coverage Δ
unittests 52.69% <16.84%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctjhoa ctjhoa marked this pull request as ready for review September 27, 2024 13:12
@ctjhoa ctjhoa requested a review from RemiBonnet September 27, 2024 13:14
@ctjhoa ctjhoa force-pushed the FRT-1306-add-the-cloud-provider-selection-view-before-entering-the-cluster-creation-flow branch 2 times, most recently from c6334cb to aaf1b63 Compare September 27, 2024 15:29
@ctjhoa ctjhoa force-pushed the FRT-1306-add-the-cloud-provider-selection-view-before-entering-the-cluster-creation-flow branch from aaf1b63 to a01e895 Compare September 27, 2024 15:34
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctjhoa !

@ctjhoa ctjhoa requested a review from RemiBonnet September 30, 2024 09:15
@RemiBonnet RemiBonnet merged commit 2a65540 into staging Oct 2, 2024
@RemiBonnet RemiBonnet deleted the FRT-1306-add-the-cloud-provider-selection-view-before-entering-the-cluster-creation-flow branch October 2, 2024 09:06
@RemiBonnet
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.159.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants