Skip to content

fix(entrypoint-cmd): add missing image tag#1734

Merged
RemiBonnet merged 1 commit intostagingfrom
fix/entrypoint-cmd-inputs-image-tag
Oct 23, 2024
Merged

fix(entrypoint-cmd): add missing image tag#1734
RemiBonnet merged 1 commit intostagingfrom
fix/entrypoint-cmd-inputs-image-tag

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Oct 23, 2024

What does this PR do?

Add missing image_tag for docker cmd preview


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Copy Markdown
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

One day they will all understand

@RemiBonnet RemiBonnet marked this pull request as ready for review October 23, 2024 07:40
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Oct 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a07bfe1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.03%. Comparing base (b269efb) to head (a07bfe1).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...entrypoint-cmd-inputs/ui/entrypoint-cmd-inputs.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1734      +/-   ##
===========================================
+ Coverage    53.06%   59.03%   +5.97%     
===========================================
  Files          931      301     -630     
  Lines        12459     5378    -7081     
  Branches      3614     1635    -1979     
===========================================
- Hits          6611     3175    -3436     
+ Misses        4618     1619    -2999     
+ Partials      1230      584     -646     
Flag Coverage Δ
unittests 59.03% <33.33%> (+5.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet merged commit a575793 into staging Oct 23, 2024
@RemiBonnet RemiBonnet deleted the fix/entrypoint-cmd-inputs-image-tag branch October 23, 2024 07:46
@RemiBonnet
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.162.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant