feat(application-container-creation-flow): add general step#2451
feat(application-container-creation-flow): add general step#2451rmnbrd merged 10 commits intonew-navigationfrom
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
RemiBonnet
force-pushed
the
feat/new-nav/application-general
branch
from
14dada9 to
e7c1229
Compare
…ge and update navigation links
…ion container flow with template support
… and remove unused imports
…grate into feature exports
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2451 +/- ##
=================================================
Coverage ? 44.42%
=================================================
Files ? 558
Lines ? 12592
Branches ? 3632
=================================================
Hits ? 5594
Misses ? 6061
Partials ? 937
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const watchFieldProvider = watch('source_provider') | ||
| const isLifecycleJob = service?.serviceType === 'JOB' && service.job_type === 'LIFECYCLE' | ||
|
|
||
| const ContainerSettings = ({ isSetting }: { isSetting?: boolean }) => { |
There was a problem hiding this comment.
This function will be recalculated each time the parent component renders. Could you please cache it?
But more importantly, why do we have this function? It just returns another component. I'm not sure to understand why it's needed.
There was a problem hiding this comment.
This one is in the page folder not necessary for the new-nav we will remove it, I remove it to avoid confusion
| }, | ||
| }) | ||
| } | ||
| renderEditGitSettings={() => <EditGitRepositorySettingsFeature />} |
There was a problem hiding this comment.
What's the benefit of having these render props instead of what we had before?
There was a problem hiding this comment.
Avoid circular dependencies and removing console-shared lib, but I'll move EditGitRepositorySettingsFeature inside the domains organization because we want to remove console-shared lib. This one is part of the General Settings for Service, I was mainly focus of the step-general in the creation flow for this PR
| const dataTemplate = serviceTemplates.find((service) => service.slug === slug) | ||
| const dataOptionTemplate = option !== 'current' ? findTemplateData(slug, option) : null | ||
|
|
||
| const ContainerSettings = ({ organizationId }: { organizationId: string }) => { |
There was a problem hiding this comment.
Same here. Why do we have this new function?
There was a problem hiding this comment.
We will remove it when the flow is finish, I remove it to avoid confusion
…ditGitRepositorySettings components with modal support for token management
2 participants
Summary
Started creation flow for Application and Container with general step
service/create/container/general?template=reactshared/console-sharedlibrary todomains/services/featuresto avoid circular dependencies for all general steps (jobs as well)Screenshots / Recordings
https://www.loom.com/share/968dd6cadb00494b978c344ccc88e26a
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release