Skip to content

fix(variable-list): show service link in built-in list#2452

Merged
RemiBonnet merged 2 commits intonew-navigationfrom
fix/new-nav/service-variables
Mar 6, 2026
Merged

fix(variable-list): show service link in built-in list#2452
RemiBonnet merged 2 commits intonew-navigationfrom
fix/new-nav/service-variables

Conversation

@RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Mar 6, 2026

Summary

Add "show link" in built-in for service

Screenshots / Recordings

Screenshot 2026-03-06 at 13 44 02

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

…riableList component

- Updated class names for better readability and consistency.
- Adjusted layout properties for various elements to enhance visual alignment.
- Improved snapshot tests to reflect the updated styles and structure.
@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@RemiBonnet RemiBonnet marked this pull request as ready for review March 6, 2026 12:44
@Qovery Qovery deleted a comment from cursor bot Mar 6, 2026
… changes

- Adjusted class names for improved consistency and readability.
- Updated snapshot tests to match the new layout and styling of the VariableList component.
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@44ffd03). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2452   +/-   ##
=================================================
  Coverage                  ?   44.42%           
=================================================
  Files                     ?      576           
  Lines                     ?    12847           
  Branches                  ?     3700           
=================================================
  Hits                      ?     5707           
  Misses                    ?     6189           
  Partials                  ?      951           
Flag Coverage Δ
unittests 44.42% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet added the V5 label Mar 6, 2026
@RemiBonnet RemiBonnet merged commit 65105c3 into new-navigation Mar 6, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/service-variables branch March 6, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants