Skip to content

feat(new-nav): add env deployment details view#2460

Merged
rmnbrd merged 15 commits intonew-navigationfrom
feat/new-nav/deployment-detail
Mar 11, 2026
Merged

feat(new-nav): add env deployment details view#2460
rmnbrd merged 15 commits intonew-navigationfrom
feat/new-nav/deployment-detail

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Mar 9, 2026

Summary

PR adding the env deployment details view (aka pipeline view)

Screenshots / Recordings

https://www.loom.com/share/a0892d261a264422b642a50f7e054d9b

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

One day they will all understand

@rmnbrd rmnbrd added the V5 label Mar 9, 2026
@rmnbrd rmnbrd self-assigned this Mar 9, 2026
@rmnbrd rmnbrd force-pushed the feat/new-nav/deployment-detail branch from 0c0ba60 to c741001 Compare March 10, 2026 10:46
@rmnbrd rmnbrd force-pushed the feat/new-nav/deployment-detail branch from fa63b48 to c4bdf8d Compare March 10, 2026 14:49
@rmnbrd rmnbrd force-pushed the feat/new-nav/deployment-detail branch from c4bdf8d to bd220b1 Compare March 10, 2026 14:58
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 8.82353% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.91%. Comparing base (d71be04) to head (856cfd5).
⚠️ Report is 4 commits behind head on new-navigation.

Files with missing lines Patch % Lines
.../lib/environment-pipeline/environment-pipeline.tsx 0.00% 52 Missing ⚠️
...nt-deployment-list/environment-deployment-list.tsx 28.57% 5 Missing ⚠️
...yment-list/dropdown-services/dropdown-services.tsx 42.85% 4 Missing ⚠️
...xecution-id/use-deployment-history-execution-id.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2460      +/-   ##
==================================================
- Coverage           43.63%   42.91%   -0.73%     
==================================================
  Files                1058     1008      -50     
  Lines               20329    19652     -677     
  Branches             5871     5722     -149     
==================================================
- Hits                 8870     8433     -437     
+ Misses               9872     9704     -168     
+ Partials             1587     1515      -72     
Flag Coverage Δ
unittests 42.91% <8.82%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd marked this pull request as ready for review March 10, 2026 15:06
@rmnbrd rmnbrd requested a review from RemiBonnet March 10, 2026 15:54
Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @rmnbrd! A few comments below:

  • Could we fix the alignment of the (i) inside the item list?
Image Image
  • I think we need to improve the scrolling in this view. I see two possible solutions, but let's also get @TheoGrandin74 's advice:
    -- Add shadows on the left and right when the content is scrollable
    -- Remove the container for this view, start with left alignment, and allow scrolling across the full width
Image
  • We have a scroll even though it's not necessary, could you fix it?
Image
  • I feel the loading state is longer than what we currently have in production. It might be because we use Suspense for all requests (including the WebSocket). Perhaps we could avoid using Suspense for the status and add a skeleton instead? Let me know what you think 😄

@TheoGrandin74
Copy link
Contributor

TheoGrandin74 commented Mar 11, 2026

@rmnbrd Hey, some feedbacks on it following also @RemiBonnet message:

  • For the horizontal scroll, after testing a bit I think the better option would be to have a shadow/gradient at the end of the container when the content is bigger than the container, and also have one at the beginning once I'm scrolling on it. I've mockup it here if you want to have a look
  • For the hover on the service card, I know we've talked about it and after testing I think we can maybe add a small hover:bg-surface-neutral-subtle on it just to make it a tad clearer
  • Let's also reduce the gap between all elements at gap-3 instead of gap-4 here to be consistent with the service logs image
  • The "Deploy" button also is a bit in an awkward place and not really visible/easily to mix with the status of the deploy, so it could be great to have it as a real button in the left like that image

I have a couple of nice to have feedback also, by no mean necessary but if we have some time it would improve the design a bit:

  • To have a real title heading on the page
  • To have as a title the name of the operation + status, as you are already on the environment I think repeating it is a bit redundant and the import stuff to know here is to know if it was a deploy/stop/delete/other and know if this operation was successful or not. This would mean having something like that as the title, and then have the rest of the metadata as we have them currently. But nice to have as I said, not the most important!
image

@rmnbrd rmnbrd merged commit e83bbba into new-navigation Mar 11, 2026
10 of 11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/deployment-detail branch March 11, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants