feat(new-nav): add env deployment details view#2460
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
0c0ba60 to
c741001
Compare
fa63b48 to
c4bdf8d
Compare
c4bdf8d to
bd220b1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2460 +/- ##
==================================================
- Coverage 43.63% 42.91% -0.73%
==================================================
Files 1058 1008 -50
Lines 20329 19652 -677
Branches 5871 5722 -149
==================================================
- Hits 8870 8433 -437
+ Misses 9872 9704 -168
+ Partials 1587 1515 -72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Well done @rmnbrd! A few comments below:
Could we fix the alignment of the (i) inside the item list?
When we click on "See next stage", we're redirected to the deployment view, we should prevent this click. You can try [here](http://localhost:4200/organization/141c07c8-0dd9-4623-983b-3fdd61867255/project/bea1d9f2-5fff-4308-8262-3c042d1b5192/environment/dd7dc314-acf9-4f68-a50a-efb6f78fc20b/deployments)
- I think we need to improve the scrolling in this view. I see two possible solutions, but let's also get @TheoGrandin74 's advice:
-- Add shadows on the left and right when the content is scrollable
-- Remove the container for this view, start with left alignment, and allow scrolling across the full width
We have a scroll even though it's not necessary, could you fix it?
I feel the loading state is longer than what we currently have in production. It might be because we use Suspense for all requests (including the WebSocket). Perhaps we could avoid using Suspense for the status and add a skeleton instead? Let me know what you think 😄
...anizationId/project/$projectId/environment/$environmentId/deployment/$deploymentId/index.tsx
Show resolved
Hide resolved
...anizationId/project/$projectId/environment/$environmentId/deployment/$deploymentId/index.tsx
Outdated
Show resolved
Hide resolved
|
@rmnbrd Hey, some feedbacks on it following also @RemiBonnet message:
I have a couple of nice to have feedback also, by no mean necessary but if we have some time it would improve the design a bit:
|



Summary
PR adding the env deployment details view (aka pipeline view)
Screenshots / Recordings
https://www.loom.com/share/a0892d261a264422b642a50f7e054d9b