Skip to content

feat(services): add resources settings#2461

Merged
RemiBonnet merged 1 commit intonew-navigationfrom
feat/new-nav/service-resources-settings
Mar 10, 2026
Merged

feat(services): add resources settings#2461
RemiBonnet merged 1 commit intonew-navigationfrom
feat/new-nav/service-resources-settings

Conversation

@RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Mar 10, 2026

Summary

Add Resources settings for all services and delete deprecated files

Screenshots / Recordings

https://www.loom.com/share/a2f98e9e24244312b19f36d0a2827bcd

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@RemiBonnet RemiBonnet marked this pull request as ready for review March 10, 2026 14:27
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 27.20588% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.89%. Comparing base (d71be04) to head (a5297d8).
⚠️ Report is 3 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...-resources-settings/service-resources-settings.tsx 25.00% 37 Missing and 17 partials ⚠️
...resources-settings/database-resources-settings.tsx 36.53% 19 Missing and 14 partials ⚠️
...-resources-settings/service-resources-settings.tsx 0.00% 12 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2461      +/-   ##
==================================================
+ Coverage           43.63%   43.89%   +0.26%     
==================================================
  Files                1058      652     -406     
  Lines               20329    14791    -5538     
  Branches             5871     4340    -1531     
==================================================
- Hits                 8870     6493    -2377     
+ Misses               9872     7150    -2722     
+ Partials             1587     1148     -439     
Flag Coverage Δ
unittests 43.89% <27.20%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet added the V5 label Mar 10, 2026
Copy link
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@RemiBonnet RemiBonnet merged commit 5b5b3ff into new-navigation Mar 10, 2026
14 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/service-resources-settings branch March 10, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants