Skip to content

feat(service-healthchecks): add creation flow and settings#2466

Merged
RemiBonnet merged 2 commits intonew-navigationfrom
feat/new-nav/application-healthcheck
Mar 12, 2026
Merged

feat(service-healthchecks): add creation flow and settings#2466
RemiBonnet merged 2 commits intonew-navigationfrom
feat/new-nav/application-healthcheck

Conversation

@RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Mar 11, 2026

Summary

Healthchecks settings and step in the creation flow for application and container

Screenshots / Recordings

Screenshot 2026-03-12 at 09 07 41 Screenshot 2026-03-12 at 09 08 32

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Programs must be written for people to read, and only incidentally for machines to execute

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 39.56835% with 84 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@9326b7c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...gs/application-container-healthchecks-settings.tsx 0.00% 24 Missing ⚠️
...shared/util-js/src/lib/format-healthcheck-probe.ts 28.57% 10 Missing and 10 partials ⚠️
...ation-container-healthchecks/healthchecks-utils.ts 29.62% 16 Missing and 3 partials ⚠️
...s-form/application-container-healthchecks-form.tsx 71.42% 3 Missing and 7 partials ⚠️
...althchecks/step-healthchecks/step-healthchecks.tsx 63.63% 6 Missing and 2 partials ⚠️
...t-settings/application-container-port-settings.tsx 0.00% 2 Missing ⚠️
libs/shared/util-js/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2466   +/-   ##
=================================================
  Coverage                  ?   42.62%           
=================================================
  Files                     ?     1052           
  Lines                     ?    20711           
  Branches                  ?     6014           
=================================================
  Hits                      ?     8828           
  Misses                    ?    10271           
  Partials                  ?     1612           
Flag Coverage Δ
unittests 42.62% <39.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet marked this pull request as ready for review March 12, 2026 07:40
@TheoGrandin74
Copy link
Contributor

@RemiBonnet Two quick feedback:

  • Can we maybe make it so the callout is below the heading section and divider? It will look cleaner and be more consistent with the other setting pages image
  • Also noticed that the header for both Health Checks and Port pages are not "full size" like the other settings page (general/resources but also other settings page like org settings etc.)

@RemiBonnet RemiBonnet merged commit 28b7a13 into new-navigation Mar 12, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/application-healthcheck branch March 12, 2026 11:37
@RemiBonnet RemiBonnet added the V5 label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants