Skip to content

fix(statuses): remove WS workarounds - part 1#2510

Merged
rmnbrd merged 1 commit intostagingfrom
fix/ws/unavailable-status-QOV-1727
Mar 19, 2026
Merged

fix(statuses): remove WS workarounds - part 1#2510
rmnbrd merged 1 commit intostagingfrom
fix/ws/unavailable-status-QOV-1727

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Mar 19, 2026

Summary

Issue: QOV-1727

This PR:

  • Updates the condition asserting wether the status is unavailable or not (in the useStatusWebSockets hook)
  • bumps the qovery-typescript-axios to its latest version (allowing us to use the new UNAVAILABLE status)
  • Updates the StatusChip component so it supports the new UNAVAILABLE status
  • Adds several comments to prepare the upcoming PR that will get rid workarounds altogether.
Screenshot 2026-03-19 at 16 35 51 Screenshot 2026-03-19 at 16 29 29

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@jul-dan
Copy link
Copy Markdown
Contributor

jul-dan commented Mar 19, 2026

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

One day they will all understand

@rmnbrd rmnbrd self-assigned this Mar 19, 2026
@rmnbrd rmnbrd marked this pull request as ready for review March 19, 2026 15:43
@rmnbrd rmnbrd requested a review from RemiBonnet March 19, 2026 15:43
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.30%. Comparing base (51f49e3) to head (d49cafe).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../ui/src/lib/components/status-chip/status-chip.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2510      +/-   ##
===========================================
- Coverage    49.44%   47.30%   -2.15%     
===========================================
  Files          635     1274     +639     
  Lines        14354    23705    +9351     
  Branches      4381     6991    +2610     
===========================================
+ Hits          7098    11214    +4116     
- Misses        5926    10347    +4421     
- Partials      1330     2144     +814     
Flag Coverage Δ
unittests 47.30% <0.00%> (-2.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit 7a3b674 into staging Mar 19, 2026
12 of 13 checks passed
@rmnbrd rmnbrd deleted the fix/ws/unavailable-status-QOV-1727 branch March 19, 2026 15:53
@RemiBonnet
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.297.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants