Skip to content

feat(routes): add cloud shell routes for clusters and services#2521

Merged
rmnbrd merged 10 commits intonew-navigationfrom
feat/new-nav/shell-tabs
Mar 24, 2026
Merged

feat(routes): add cloud shell routes for clusters and services#2521
rmnbrd merged 10 commits intonew-navigationfrom
feat/new-nav/shell-tabs

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

@TheoGrandin74 TheoGrandin74 commented Mar 20, 2026

Summary

  • Added a specific "Cloud shell" tab for both services and clusters
  • Removed cloud shell button in service and cluster actions
  • Modifications on service and cluster terminal to remove useless close shell, remove grabber to change size and created the integration in a single page

Screens
image
image

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Make it work, make it right, make it fast

@TheoGrandin74 TheoGrandin74 marked this pull request as ready for review March 20, 2026 15:37
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@dfaccdb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...b/hooks/use-service-summary/use-service-summary.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2521   +/-   ##
=================================================
  Coverage                  ?   44.63%           
=================================================
  Files                     ?      695           
  Lines                     ?    16110           
  Branches                  ?     4744           
=================================================
  Hits                      ?     7190           
  Misses                    ?     7606           
  Partials                  ?     1314           
Flag Coverage Δ
unittests 44.63% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheoGrandin74 !

Could you remove this file service-search-params.ts because it's useless now?

I think you need to recalculate the height because the scroll isn't correct: https://www.loom.com/share/0538fd763e4449b09a397bfad7b11d5b

@RemiBonnet RemiBonnet self-requested a review March 23, 2026 14:52
@rmnbrd rmnbrd merged commit 800c143 into new-navigation Mar 24, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/shell-tabs branch March 24, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants