Skip to content

fix(audit-logs): fix tokenization issues and small visual jumps when adding filters#2537

Merged
RemiBonnet merged 4 commits intonew-navigationfrom
feat/new-nav/audit-logs-design-improvments
Mar 25, 2026
Merged

fix(audit-logs): fix tokenization issues and small visual jumps when adding filters#2537
RemiBonnet merged 4 commits intonew-navigationfrom
feat/new-nav/audit-logs-design-improvments

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

Summary

  • Missing tokenization on the empty state
  • Add missing bg-surface-neutral on the table
  • Fixed visual jump that was occurring when we add a filter on the table
  • Fixed truncate bug with long event text

Before
image
image

After
image
image

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Take rest sometimes

@TheoGrandin74 TheoGrandin74 changed the title Feat/new nav/audit logs design improvments fix(audit-logs): fix tokenization issues and small visual jumps when adding filters Mar 24, 2026
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's way better than what it used to be! LGTM 👍

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.80%. Comparing base (226ecee) to head (a8dea11).
⚠️ Report is 13 commits behind head on new-navigation.

Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2537      +/-   ##
==================================================
- Coverage           44.88%   44.80%   -0.09%     
==================================================
  Files                1112     1051      -61     
  Lines               22205    21024    -1181     
  Branches             6418     6168     -250     
==================================================
- Hits                 9967     9419     -548     
+ Misses              10426     9904     -522     
+ Partials             1812     1701     -111     
Flag Coverage Δ
unittests 44.80% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to add a font-code title to be iso with other table?

@RemiBonnet RemiBonnet merged commit f6ee9e6 into new-navigation Mar 25, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/audit-logs-design-improvments branch March 25, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants