Skip to content

feat(environment): add version dropdown to env deployment details view#2538

Merged
rmnbrd merged 2 commits intonew-navigationfrom
feat/new-nav/deployment-details-execution-dropdown
Mar 25, 2026
Merged

feat(environment): add version dropdown to env deployment details view#2538
rmnbrd merged 2 commits intonew-navigationfrom
feat/new-nav/deployment-details-execution-dropdown

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Mar 25, 2026

Summary

This PR adds a dropdown to the deployment view, allowing users to select the executionId.

Screenshots / Recordings

https://www.loom.com/share/ca5cd79816954f14a282c342b27fb975

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@rmnbrd rmnbrd self-assigned this Mar 25, 2026
@rmnbrd rmnbrd added the V5 label Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@94ec683). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../src/lib/environment-stages/environment-stages.tsx 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2538   +/-   ##
=================================================
  Coverage                  ?   33.33%           
=================================================
  Files                     ?        7           
  Lines                     ?      123           
  Branches                  ?       48           
=================================================
  Hits                      ?       41           
  Misses                    ?       71           
  Partials                  ?       11           
Flag Coverage Δ
unittests 33.33% <60.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd marked this pull request as ready for review March 25, 2026 11:44
Copilot AI review requested due to automatic review settings March 25, 2026 11:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an execution/deployment selection control to the environment deployment details (pipeline) view so users can switch between historical executions from the header area.

Changes:

  • Added a deployment-history dropdown (with timestamps + status chips) to the environment stages header actions.
  • Updated the environment stages header to show execution id (trimmed) with a tooltip.
  • Extended unit tests with additional mocks for TanStack Router params and deployment history hooks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
libs/domains/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.tsx Reads deploymentId from TanStack Router params and shows a trimmed execution id badge; switches status chip to use deploymentHistory.
libs/domains/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.spec.tsx Adds mocks for TanStack Router + deployment history, but currently out of sync with updated props/param names.
libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.tsx Adds deployment-history dropdown (fetches history list) and moves “Hide skipped” toggle below header divider.
libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.spec.tsx Adds deployment-history hook mocking to support the new dropdown dependency.
Comments suppressed due to low confidence (1)

libs/domains/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.spec.tsx:78

  • HeaderEnvironmentStagesProps no longer includes an environment prop, but this test still builds defaultProps with environment, which will fail type-checking/build. Remove environment from the test props (and adjust any related assertions if needed).
  const defaultProps: HeaderEnvironmentStagesProps = {
    environment: {
      name: 'Test Environment',
      cloud_provider: {
        provider: 'AWS',
      },
    },
    environmentStatus: {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 a few small comments:

  • Could you add a hover state on the "Deployment history" button similar to what we have for "Last deployments" for example?

  • We currently have two different behaviors when we change the execution id. I think we should fix the deployment logs side so that we always see the dropdown: https://www.loom.com/share/c82e564d90af4580b26bb4e9aadff4cc

@RemiBonnet RemiBonnet self-requested a review March 25, 2026 11:56
@rmnbrd rmnbrd merged commit 22e853e into new-navigation Mar 25, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/deployment-details-execution-dropdown branch March 25, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants