feat(environment): add version dropdown to env deployment details view#2538
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2538 +/- ##
=================================================
Coverage ? 33.33%
=================================================
Files ? 7
Lines ? 123
Branches ? 48
=================================================
Hits ? 41
Misses ? 71
Partials ? 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds an execution/deployment selection control to the environment deployment details (pipeline) view so users can switch between historical executions from the header area.
Changes:
- Added a deployment-history dropdown (with timestamps + status chips) to the environment stages header actions.
- Updated the environment stages header to show execution id (trimmed) with a tooltip.
- Extended unit tests with additional mocks for TanStack Router params and deployment history hooks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| libs/domains/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.tsx | Reads deploymentId from TanStack Router params and shows a trimmed execution id badge; switches status chip to use deploymentHistory. |
| libs/domains/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.spec.tsx | Adds mocks for TanStack Router + deployment history, but currently out of sync with updated props/param names. |
| libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.tsx | Adds deployment-history dropdown (fetches history list) and moves “Hide skipped” toggle below header divider. |
| libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.spec.tsx | Adds deployment-history hook mocking to support the new dropdown dependency. |
Comments suppressed due to low confidence (1)
libs/domains/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.spec.tsx:78
HeaderEnvironmentStagesPropsno longer includes anenvironmentprop, but this test still buildsdefaultPropswithenvironment, which will fail type-checking/build. Removeenvironmentfrom the test props (and adjust any related assertions if needed).
const defaultProps: HeaderEnvironmentStagesProps = {
environment: {
name: 'Test Environment',
cloud_provider: {
provider: 'AWS',
},
},
environmentStatus: {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ins/environment-logs/feature/src/lib/header-environment-stages/header-environment-stages.tsx
Show resolved
Hide resolved
libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.tsx
Show resolved
Hide resolved
...nvironment-logs/feature/src/lib/header-environment-stages/header-environment-stages.spec.tsx
Show resolved
Hide resolved
libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.tsx
Show resolved
Hide resolved
libs/domains/environment-logs/feature/src/lib/environment-stages/environment-stages.tsx
Show resolved
Hide resolved
RemiBonnet
left a comment
There was a problem hiding this comment.
LGTM 👍 a few small comments:
-
Could you add a hover state on the "Deployment history" button similar to what we have for "Last deployments" for example?
-
We currently have two different behaviors when we change the execution id. I think we should fix the deployment logs side so that we always see the dropdown: https://www.loom.com/share/c82e564d90af4580b26bb4e9aadff4cc
Summary
This PR adds a dropdown to the deployment view, allowing users to select the executionId.
Screenshots / Recordings
https://www.loom.com/share/ca5cd79816954f14a282c342b27fb975