Skip to content

fix(login): ensure safe redirection after authentication by validating redirect paths#2541

Merged
rmnbrd merged 2 commits intonew-navigationfrom
fix/new-nav/login-and-port-modal
Mar 25, 2026
Merged

fix(login): ensure safe redirection after authentication by validating redirect paths#2541
rmnbrd merged 2 commits intonew-navigationfrom
fix/new-nav/login-and-port-modal

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Mar 25, 2026

Summary

  • Fix port modal size + I updated the name to be less confusing (Slack)
  • Fix /login ensure safe redirection (Slack)

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review March 25, 2026 15:45
@RemiBonnet
Copy link
Copy Markdown
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Help yourself at 2AM by putting some metrics to help observability

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@f6ee9e6). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2541   +/-   ##
=================================================
  Coverage                  ?   41.81%           
=================================================
  Files                     ?       23           
  Lines                     ?      672           
  Branches                  ?      209           
=================================================
  Hits                      ?      281           
  Misses                    ?      316           
  Partials                  ?       75           
Flag Coverage Δ
unittests 41.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit 7ad74dd into new-navigation Mar 25, 2026
13 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/login-and-port-modal branch March 25, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants